Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the import logic of paging #2837

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Conversation

kazrael2119
Copy link
Contributor

No description provided.

@MaryGao MaryGao marked this pull request as ready for review September 24, 2024 03:13
@@ -63,15 +63,6 @@ export function generateModelFiles(
modelsFile.addInterfaces(objectsDefinitions);
modelsFile.addTypeAliases(objectTypeAliases);
modelsFile.addTypeAliases(objectAliases);
if (importedModels.has("Paged")) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could help double check any other places including Paged, paging or core-paging?

Copy link
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for removing useless code.

@MaryGao MaryGao merged commit 363400b into Azure:main Sep 24, 2024
15 checks passed
@kazrael2119 kazrael2119 deleted the remove-paging branch September 24, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants