Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get paging properties from parent models #2764

Merged
merged 10 commits into from
Sep 5, 2024

Conversation

kazrael2119
Copy link
Contributor

@kazrael2119 kazrael2119 commented Aug 22, 2024

fixes #2752

@kazrael2119 kazrael2119 changed the title get properties from parent models Get paging properties from parent models Aug 22, 2024
@MaryGao MaryGao marked this pull request as ready for review September 5, 2024 03:23
/**
* Deduplicates properties from an object by removing duplicated ones
*/
function deduplicateProperties(
Copy link
Member

@MaryGao MaryGao Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kazrael2119 pls verify in billing RP and fix the ci issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
this works for billing

Copy link
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaryGao MaryGao merged commit 8c1b615 into Azure:main Sep 5, 2024
15 checks passed
@kazrael2119 kazrael2119 deleted the fix-parent-model-ref branch September 5, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants