-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bearer
to Bearer
#2576
Update bearer
to Bearer
#2576
Conversation
securityInfo.customHttpAuthSharedKeyPrefix = auth.scheme; | ||
// If it is basic or bearer auth we should generate it as Basic or Bearer | ||
securityInfo.customHttpAuthSharedKeyPrefix = [ | ||
"basic", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where do we set Basic now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be the same as bearer in header.
https://swagger.io/docs/specification/authentication/basic-authentication/
Authorization: Basic ZGVtbzpwQDU1dzByZA==
Bearer
https://swagger.io/docs/specification/authentication/bearer-authentication/
Authorization: Bearer <token>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixes #2572
fixes #2109