Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should ignore client.tsp config in rlc #1896

Merged
merged 11 commits into from
Jun 29, 2023
Merged

Should ignore client.tsp config in rlc #1896

merged 11 commits into from
Jun 29, 2023

Conversation

qiaozha
Copy link
Member

@qiaozha qiaozha commented Jun 16, 2023 •
edited
Loading

fixes #1891
And refactored the code in typespec-ts a little to move all utils related file into utils folder.
Also, removed the multiclient test case in the typespec-test folder, giving we have a real case of loadTest in RLC as the multi-client in test case.

@xirzec xirzec requested a review from mpodwysocki June 16, 2023 20:31
xirzec
xirzec reviewed Jun 16, 2023
View reviewed changes
Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments on how we calculate the clients, I don't think we actually need any changes to generator-core.

The other refactorings (moving utils and removing the other test case) look good.

packages/typespec-ts/src/utils/clientUtils.ts Outdated Show resolved Hide resolved
xirzec
xirzec approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this approach, modulo the breaking change concern when a second client is added to a service namespace.

packages/typespec-ts/src/utils/clientUtils.ts Outdated Show resolved Hide resolved
packages/typespec-ts/src/utils/clientUtils.ts Outdated Show resolved Hide resolved
packages/typespec-ts/src/utils/clientUtils.ts Outdated Show resolved Hide resolved
xirzec
xirzec approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and I believe this matches the feedback.

@bterlson @witemple-msft @mpodwysocki any concerns with merging this?

packages/typespec-ts/src/utils/clientUtils.ts Show resolved Hide resolved
MaryGao
MaryGao approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiaozha qiaozha merged commit efb25ef into Azure:main Jun 29, 2023
@qiaozha qiaozha deleted the should-ignore-client.tsp-config-in-rlc branch June 29, 2023 23:56
@wanlwanl wanlwanl mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryGao MaryGao MaryGao approved these changes

@xirzec xirzec xirzec approved these changes

@sarangan12 sarangan12 Awaiting requested review from sarangan12 sarangan12 is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DPG] Ignore the client.tsp in RLC generation
3 participants
@qiaozha @xirzec @MaryGao