Fix ArgumentNullException when Generating without docs -NoDocs
switch
#711
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the code path below, throws
ArgumentNullException
whenExport-ProxyCmdlet
is invoked in the-NoDocs
code path.autorest.powershell/powershell/resources/assets/build-module.ps1
Lines 123 to 134 in f9b8e88
Exception is thrown here at
Path.Combine
, sinceExamplesFolder
will be null.autorest.powershell/powershell/resources/psruntime/BuildTime/Cmdlets/ExportProxyCmdlet.cs
Line 76 in 6390998
Solution
Allow
ExamplesFolder
to be passed along for all param sets, since examples are already always generated. (Example Stubs).autorest.powershell/powershell/resources/psruntime/BuildTime/Cmdlets/ExportProxyCmdlet.cs
Lines 45 to 47 in 6390998
Pass along
-ExamplesFolder
since its required in all code paths.