Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make data-plane default tag #2146

Merged
merged 15 commits into from
Apr 13, 2022
Merged

Make data-plane default tag #2146

merged 15 commits into from
Apr 13, 2022

Conversation

chunyu3
Copy link
Member

@chunyu3 chunyu3 commented Apr 6, 2022

Description

Add your description here!

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

chunyu3 added 14 commits December 10, 2021 10:59
@chunyu3
update shared source
84feebb
@chunyu3
Merge branch 'feature/v3' of https://github.com/Azure/autorest.csharp …
27776ea 
…into feature/v3
@chunyu3
Merge branch 'feature/v3' of https://github.com/Azure/autorest.csharp …
0c463a1 
…into feature/v3
@chunyu3
Merge branch 'feature/v3' of https://github.com/Azure/autorest.csharp …
0ac847d 
…into feature/v3
@chunyu3
Merge pull request #1 from Azure/feature/v3
bf99cb4 
rebase
@chunyu3
Merge branch 'feature/v3' of https://github.com/chunyu3/autorest.csharp…
0c2330a 
… into feature/v3
@chunyu3
Merge branch 'feature/v3' of https://github.com/Azure/autorest.csharp …
1c33d0b 
…into feature/v3
@chunyu3
Merge branch 'feature/v3' of https://github.com/Azure/autorest.csharp …
57de39b 
…into feature/v3
@chunyu3
Merge branch 'feature/v3' of https://github.com/Azure/autorest.csharp …
8c46cd1 
…into renameTaget
@chunyu3
update Generate.ps1
e488515
@chunyu3
Merge pull request #3 from Azure/feature/v3
d3c92da 
rebase
@chunyu3
Merge branch 'feature/v3' of https://github.com/chunyu3/autorest.csharp…
9c09471 
… into renameTaget
@chunyu3
update test
ad29013
@chunyu3
remove data-plane flag
2951642
@chunyu3 chunyu3 mentioned this pull request Apr 6, 2022
Closed
3 tasks
@annelo-msft
Copy link
Member

Would you please link the issue number this is addressing in the PR description? This makes it easier to find the PR from the issue.

@chunyu3
Copy link
Member Author

chunyu3 commented Apr 7, 2022

Would you please link the issue number this is addressing in the PR description? This makes it easier to find the PR from the issue.

attached the issue link

@chunyu3 chunyu3 requested a review from annelo-msft April 7, 2022 00:48
@lirenhe lirenhe added the DPG label Apr 7, 2022
annelo-msft
annelo-msft reviewed Apr 7, 2022
View reviewed changes
Copy link
Member

@annelo-msft annelo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests and samples LGTM, @AlexanderSher should approve src/*.

We should make sure to closely review the PR to move this into azure-sdk-for-net repo.

samples/Azure.AI.DocumentTranslation/Generated/Configuration.json
@@ -7,6 +7,5 @@
"..\\..\\..\\artifacts\\bin\\AutoRest.CSharp\\Debug\\netcoreapp3.1\\Azure.Core.Shared"
],
"public-clients": true,
"skip-csproj-packagereference": true,
"data-plane": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious: What is the reason that data-plane: true is removed here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DPG is default target. if neither azure-arm nor generation1-convenience-client is set, it will be DPG. No need a flag for DPG.

test/TestProjects/ResourceClients-LowLevel/readme.md
@@ -5,7 +5,6 @@
``` yaml
require: $(this-folder)/../../../readme.md
input-file: $(this-folder)/ResourceClients-LowLevel.json
data-plane: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we keep this setting in the manually-edited files?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to maintain data-plane flag anymore. if neither azure-arm nor generation1-convenience-client is set, it will be DPG. No need a flag for DPG.

Copy link
Member Author

@chunyu3 chunyu3 Apr 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we only have two flags for customer to set. azure-am for management-plane, eneration1-convenience-client is for HLC.

@chunyu3 chunyu3 requested a review from annelo-msft April 8, 2022 00:10
@AlexanderSher
Copy link
Contributor

Mostly ok, but I'm not sure about generation1ConvenienceClient name. It is very confusing. It isn't a track 1 generator

@chunyu3 chunyu3 requested a review from AlexanderSher April 8, 2022 14:42
@chunyu3 chunyu3 mentioned this pull request Apr 13, 2022
Closed
@chunyu3 chunyu3 mentioned this pull request Apr 13, 2022
Merged
@chunyu3 chunyu3 merged commit fee67e3 into Azure:feature/v3 Apr 13, 2022
@chunyu3 chunyu3 mentioned this pull request Apr 14, 2022
Merged
@chunyu3 chunyu3 deleted the dataPlaneTarget branch August 18, 2022 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annelo-msft annelo-msft annelo-msft approved these changes

@m-nash m-nash Awaiting requested review from m-nash

@ShivangiReja ShivangiReja Awaiting requested review from ShivangiReja

@AlexanderSher AlexanderSher Awaiting requested review from AlexanderSher

Assignees
No one assigned
Labels
DPG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chunyu3 @annelo-msft @AlexanderSher @lirenhe