This repository has been archived by the owner on Jul 14, 2023. It is now read-only.
Fix url base flag and version bump #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RodgeFu
reviewed
May 19, 2020
qiaozha
reviewed
May 19, 2020
README.md
Outdated
|
|
||
| output-folder: $(az-output-folder) | ||
| debug-output-folder: $(az-output-folder)/_az_debug | ||
|
|
||
| use-extension: | ||
| "@autorest/python": "5.0.0-preview.3" | ||
| "@autorest/python": "5.0.0-preview.7" | ||
| "@autorest/clicommon": "0.4.8" |
There was a problem hiding this comment.
@RodgeFu You still need to bump modelerfour version in autorest/clicommon into 4.13.351 and provide a new autorest/clicommon so that they are using the same modelerfour version right?
qiaozha
reviewed
May 20, 2020
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@autorest/az", | |||
| "version": "1.3.4", | |||
| "version": "1.3.5", | |||
There was a problem hiding this comment.
Don't think it's a good idea to bump the official version directlly without tried private release for at least several days.
There was a problem hiding this comment.
I have delivered preview branch to others, so it is not so urgent to release officially
0a1c66d to
88913e3
Compare
qiaozha
approved these changes
May 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.