This repository has been archived by the owner on Jul 14, 2023. It is now read-only.
extension mode configurable #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
zikalino
reviewed
May 12, 2020
| policy_name, | ||
| no_wait=False): | ||
| return sdk_no_wait(no_wait, client.begin_delete, | ||
| resource_group_name=resource_group_name, |
There was a problem hiding this comment.
there may be some python formatting lint issue here?
There was a problem hiding this comment.
I am sure this one will not cause the lint error. but please don't merge this PR for now
zikalino
approved these changes
May 12, 2020
| @@ -37,13 +38,13 @@ export function GenerateAzureCliCommands(model: CodeModelAz): string[] { | |||
| output.push(" client_factory=" + cf_name + ")"); | |||
| let groupinfos = model.CommandGroup_Name.split(' '); | |||
| let extraInfo = ""; | |||
| if(groupinfos.length == 2) { | |||
| if(groupinfos.length == 2 && model.Extension_Mode == 'experimental') { | |||
There was a problem hiding this comment.
Add similar logic when Extension_Mode is preview.
There was a problem hiding this comment.
I thought preview don't need to add this is_preview=True at the end of the command?
There was a problem hiding this comment.
If not added, it means GA.
mmyyrroonn
reviewed
May 18, 2020
| factory_name, | ||
| integration_runtime_name, | ||
| no_wait=False): | ||
| return sdk_no_wait(no_wait, client.begin_stop, |
There was a problem hiding this comment.
is it possible to have better format? :)
There was a problem hiding this comment.
what kind of format does CLI need?
There was a problem hiding this comment.
Changed, please review again.
…st.az into extension-mode-configurable
fengzhou-msft
approved these changes
May 19, 2020
mmyyrroonn
approved these changes
May 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to solve
4.1 if the operation already has parameter 'name', main resource option shouldn't be applied.
4.2 change wait_comamnd to the custom_wait_command since python sdk get operation is not always consistent with the show command parameter.
4.3 add parameter description in param.py for wait command.
4.4 allow change subgroup in the command.