Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

Support ids #350

Merged
merged 4 commits into from
May 7, 2020
Merged

Support ids #350

merged 4 commits into from
May 7, 2020

Conversation

qiaozha
Copy link
Member

@qiaozha qiaozha commented May 6, 2020

No description provided.

@qiaozha
Copy link
Member Author

qiaozha commented May 6, 2020

To fix issue #339


with self.argument_context('datafactory configure-factory-repo') as c:
c.argument('location_id', help='The location identifier.')
c.argument('location_id', help='The location identifier.', id_part='name')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks weird. What's the full path for the request url?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@fengzhou-msft fengzhou-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiaozha qiaozha merged commit 36c5d3d into master May 7, 2020
@qiaozha qiaozha deleted the support-ids branch May 7, 2020 02:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants