Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

Portal review - Recommend to add confirmation=True for delete. #285

Closed
zikalino opened this issue Apr 6, 2020 · 3 comments
Closed

Portal review - Recommend to add confirmation=True for delete. #285

zikalino opened this issue Apr 6, 2020 · 3 comments
Assignees
@qiaozha
Labels
priority_p1_important important but not blocking type_bug Something isn't working type_task_small Task at bug scope, big task should be tracked in the project file

Comments

@zikalino
Copy link

zikalino commented Apr 6, 2020

We should consider having an option to enable it?

Recommend to add confirmation=True for delete.

Originally posted by @fengzhou-msft in Azure/azure-cli-extensions#1428
@zikalino zikalino added type_bug Something isn't working priority_p1_important important but not blocking type_task_small Task at bug scope, big task should be tracked in the project file version_2020-03 labels Apr 6, 2020
@LianwMS
Copy link
Contributor

LianwMS commented Jun 12, 2020

Need confirm with Cli team

@fengzhou-msft
Copy link
Member

This needs further discussion. @myronfanqiu who drived the discussion for related linter rule.

qiaozha added a commit that referenced this issue Aug 3, 2020
@qiaozha
fix issue #486 #285
d09df12
qiaozha added a commit that referenced this issue Aug 4, 2020
@qiaozha
fix issue #486 #285 (#491)
106af00
@amecodegenbot
Copy link

Merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@qiaozha qiaozha

Labels
priority_p1_important important but not blocking type_bug Something isn't working type_task_small Task at bug scope, big task should be tracked in the project file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@LianwMS @zikalino @fengzhou-msft @qiaozha @amecodegenbot