Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend CreateUI Test Coverage #721

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Extend CreateUI Test Coverage #721

merged 2 commits into from
Dec 5, 2022

Conversation

dciborow
Copy link
Contributor

@dciborow dciborow commented Dec 5, 2022

Textboxes-With-Length-Constrains-Regex should not fail when length constraint is in the middle.

image

          {
            "name": "issuerProvider",
            "type": "Microsoft.Common.TextBox",
            "label": "Custom Issuer Provider",
            "toolTip": "certificate Issuer Provider",
            "visible": "[equals(steps('Security').issuerProviderDropDown, 'Custom')]",
            "defaultValue": "",
            "constraints": {
              "validations": [
                {
                  "regex": "^[A-Za-z][A-Za-z0-9-]{1,61}[A-Za-z0-9]$",
                  "message": "The certificate issuer can only contain alphanumeric values, and hyphens, but may not end with a hyphen."
                }
              ]
            }          
          }

Textboxes-With-Length-Constrains-Regex should not fail when length constraint is in the middle.
@dciborow dciborow changed the title Fix False Positive Extend CreateUI Test Coverage Dec 5, 2022
@bmoore-msft bmoore-msft merged commit 107056f into Azure:master Dec 5, 2022
@dciborow
Copy link
Contributor Author

dciborow commented Dec 5, 2022

When I tried to reproduce, it passed.

@dciborow dciborow deleted the patch-6 branch December 5, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants