Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extractor and publisher scripts #479

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

waelkdouh
Copy link
Contributor

Fixed some bugs in the updated code that added support for mac runners

@waelkdouh waelkdouh merged commit 68e61ad into main Feb 9, 2024
1 check passed
@Rick-healy
Copy link

hi @waelkdouh - in the Github Publisher action 'run-publisher-with-env', it looks like the fixes for whitespace in the 'if else' conditions, also the 'And' logic changes haven't made it through into the published code and subsequent releases.
Scenarios that don't have seem to have the fixes;

  • -Run publisher without Config Yaml or Commit ID
  • -Run publisher with Config Yaml and Commit id
  • -Run publisher with Config Yaml but without Commit id

@waelkdouh
Copy link
Contributor Author

hi @waelkdouh - in the Github Publisher action 'run-publisher-with-env', it looks like the fixes for whitespace in the 'if else' conditions, also the 'And' logic changes haven't made it through into the published code and subsequent releases. Scenarios that don't have seem to have the fixes;

  • -Run publisher without Config Yaml or Commit ID
  • -Run publisher with Config Yaml and Commit id
  • -Run publisher with Config Yaml but without Commit id

Great catch! I just created a new PR #509 which you can find here to address your concerns.

@guythetechie guythetechie deleted the wk/fixPSIssuesWithPipelines branch July 5, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants