Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix autogen cmd #444

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

fix autogen cmd #444

wants to merge 3 commits into from

Conversation

AllyW
Copy link
Member

@AllyW AllyW commented Jan 20, 2025

test cmd:

  1. aaz-dev command-model generate-from-swagger -a .\aaz --sm .\azure-rest-api-specs\specification\liftrpinecone -m liftrpinecone --rp Pinecone.VectorDb --swagger-tag package-2024-10-22-preview
  2. aaz-dev cli generate-by-swagger-tag -a .\aaz\ -e .\azure-cli-extensions\ --name liftrpinecone-self --sm .\azure-rest-api-specs\specification\liftrpinecone --rp Pinecone.VectorDb --tag package-2024-10-22-preview --profile latest

kairu-ms
kairu-ms reviewed Jan 21, 2025
View reviewed changes
src/aaz_dev/swagger/model/specs/_resource_provider.py
@@ -86,7 +86,7 @@ def tags(self):
self._tags = self._parse_readme_input_file_tags()
return self._tags

def _parse_readme_input_file_tags(self):
def _parse_readme_input_file_tags_v0(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean up the un used code

kairu-ms
kairu-ms reviewed Jan 21, 2025
View reviewed changes
src/aaz_dev/command/controller/workspace_manager.py Outdated
Comment on lines 1246 to 1248
if self.is_in_memory:
return None
assert not self.is_in_memory
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There must be some internal bugs, because the old code add assert below to guarantee it's not in memory . Could you find the reason why it's in memory.

Copy link
Member Author

@AllyW AllyW Jan 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_in_memory is true when the ws does not get saved in file system, (for cmd aaz-dev command-model generate-from-swagger), so it cannot be loaded from memory either.

@AllyW AllyW marked this pull request as draft February 19, 2025 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kairu-ms kairu-ms kairu-ms left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AllyW @kairu-ms