-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set specific encoding for all platforms #298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most characters are gibberish, do we need support them? Or we can filter them out from swagger source.
CodeGen, or workspace manager in Codegen here is in charge of loading and enabling the management of related api definitions in swagger file. Swagger quality and cleaning can be checked and enhanced by service developer when generating codes or by codegen developer when pre-loading swaggers (if planed later), in my view. |
It's better clean then when loading swaggers. Can you add this support in current PR? I think those can be added in this function aaz-dev-tools/src/aaz_dev/swagger/model/specs/_swagger_loader.py Lines 18 to 34 in b8386be
|
b020396
to
4b4786f
Compare
For *nix os, utf8 is default system encoding which is used when python open func is working without a given encoding format.
However, windows may use local systems encoding which might be incompatible with non-ascii characters in files.
Set encoding in file operations can avoid this error.