Update Feature Management release 2.6.1 #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenlan
reviewed
Nov 15, 2023
|
|
||
| ### Bug fix | ||
|
|
||
| * Adds edge case for EvaluateAsync call that doesn't use context from FeatureManager. |
There was a problem hiding this comment.
Fixed edge cases for ...
Is there an issue we can reference here?
There was a problem hiding this comment.
There was a problem hiding this comment.
Reference added.
zhenlan
reviewed
Nov 16, 2023
|
|
||
| ### Bug fix | ||
|
|
||
| * Adds [edge case](https://github.com/microsoft/FeatureManagement-Dotnet/issues/244) for EvaluateAsync call that doesn't use context from FeatureManager. |
There was a problem hiding this comment.
I understand we were not consistent, but we should
- use past tense
- put the referenced issue in the end
So suggest:
Fixed an edge case for ... #244
zhenlan
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.