Update FeatureManagement with V3 release notes #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyca15
approved these changes
Oct 27, 2023
zhenlan
reviewed
Oct 27, 2023
| The following passage describes the process of selecting a filter when a contextual and non-contextual filter of the same name are registered in an application. | ||
|
|
||
| Let's say we have a non-contextual filter called FilterA and two contextual filters FilterB and FilterC which accept TypeB and TypeC contexts respectively. All of three filters share the same alias "SharedFilterName". | ||
| We also have a feature flag "MyFeature" which uses the feature filter "SharedFilterName" in its configuration. |
There was a problem hiding this comment.
Update "we" to "you" for all occurrences (above and below)
zhenlan
reviewed
Oct 27, 2023
| If all of three filters are registered: | ||
| When we call IsEnabledAsync("MyFeature"), the FilterA will be used to evaluate the feature flag. | ||
| When we call IsEnabledAsync("MyFeature", context), if context's type is TypeB, FilterB will be used and if context's type is TypeC, FilterC will be used. | ||
| When we call IsEnabledAsync("MyFeature", context), if context's type is TypeF, FilterA will be used. |
There was a problem hiding this comment.
All mixed in one line in md. You may want to add bullet points in front of each line.
|
PR to fix comments: https://github.com/Azure/AppConfiguration/pull/826/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.