New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support feature flags #65

Merged

Eskibear merged 24 commits into main from yanzh/fm

Jul 30, 2024

Member

Eskibear commented May 27, 2024 •

edited

Loading

By default feature flags are excluded and cannot be loaded. Only when featureFlagOptions.enabled is true, it loads feature flags as a whole into a preserved key feature_management, according to featureFlagOptions.selectors. The refresh behavior is independently controlled by featureFlagOptions.refresh.


          support feature flags

c035f89

Eskibear requested review from avanigupta, juniwang and zhiyuanliang-ms

June 3, 2024 02:30

Eskibear marked this pull request as ready for review

June 3, 2024 02:30

avanigupta reviewed

View reviewed changes

src/AzureAppConfigurationImpl.ts Outdated Show resolved Hide resolved

avanigupta reviewed

View reviewed changes

src/AzureAppConfigurationImpl.ts Outdated Show resolved Hide resolved

avanigupta reviewed

View reviewed changes

src/RefreshOptions.ts Outdated Show resolved Hide resolved

avanigupta reviewed

View reviewed changes

src/RefreshOptions.ts Outdated Show resolved Hide resolved

avanigupta reviewed

View reviewed changes

src/featureManagement/FeatureFlagOptions.ts Show resolved Hide resolved

avanigupta reviewed

View reviewed changes

src/featureManagement/FeatureFlagOptions.ts Outdated Show resolved Hide resolved

avanigupta reviewed

View reviewed changes

src/AzureAppConfigurationImpl.ts Outdated Show resolved Hide resolved

avanigupta reviewed

View reviewed changes

src/AzureAppConfigurationImpl.ts Outdated Show resolved Hide resolved

Eskibear mentioned this pull request

Support listing by etags #67

Closed

Eskibear and others added 3 commits

June 5, 2024 11:31


          Apply suggestions from code review

Co-authored-by: Avani Gupta <avanigupta@users.noreply.github.com>


          fix default refresh interval in comments

e269596


          Merge branch 'main' of github.com:Azure/AppConfiguration-JavaScriptPr…

2d0c820

…ovider into yanzh/fm

Eskibear changed the base branch from feature-management to feature/feature-management

June 11, 2024 08:22

Eskibear added 3 commits

June 11, 2024 16:45


          update constants to SNAKE_CASE

708f759


          Merge branch 'main' into yanzh/fm

7f62f14


          use extracted list api

3cd5f59

avanigupta reviewed

View reviewed changes

src/AzureAppConfigurationImpl.ts Show resolved Hide resolved

avanigupta reviewed

View reviewed changes

src/AzureAppConfigurationImpl.ts Outdated Show resolved Hide resolved

avanigupta reviewed

View reviewed changes

src/AzureAppConfigurationImpl.ts Outdated Show resolved Hide resolved

Eskibear added 2 commits

June 12, 2024 17:18


          throw error if selectors not provided

923c124


          parse feature flag directly

8e2de54

avanigupta reviewed

View reviewed changes

src/AzureAppConfigurationImpl.ts Outdated Show resolved Hide resolved

Eskibear mentioned this pull request

log details of refresh events #75

Open

Eskibear added 2 commits

June 19, 2024 10:25


          refactor: rename validateSelectors to getValidSelectors


          refresh APIs apply for both kv and ff

99f2c29

Eskibear added 3 commits

June 20, 2024 14:50


          dedup loaded feature flags among selectors

dc4f553


          Merge branch 'main' of github.com:Azure/AppConfiguration-JavaScriptPr…

c29d834

…ovider into yanzh/fm


          extract requestTraceOptions as private member

6411a30

Eskibear commented

View reviewed changes

src/AzureAppConfigurationImpl.ts Show resolved Hide resolved


          list feature flags with pageEtags

4ec140a

Eskibear force-pushed the yanzh/fm branch from 570d96d to 4ec140a Compare

July 2, 2024 09:14


          update mocked client to support byPage iterator

453dad3

Eskibear changed the base branch from feature/feature-management to main

July 3, 2024 07:09

Eskibear added 4 commits

July 3, 2024 15:32


          handle page deletion

e4eedc9


          upgrade @azure/app-configuration to 1.6.1

87316f3


          Merge branch 'main' of github.com:Azure/AppConfiguration-JavaScriptPr…

1499cbf

…ovider into yanzh/fm


          add tests for pageEtag based refresh

0c8a4f2

avanigupta reviewed

View reviewed changes

src/AzureAppConfigurationImpl.ts Show resolved Hide resolved

avanigupta reviewed

View reviewed changes

src/AzureAppConfigurationImpl.ts Outdated Show resolved Hide resolved

src/AzureAppConfigurationImpl.ts Outdated Show resolved Hide resolved

src/AzureAppConfigurationImpl.ts Show resolved Hide resolved

src/AzureAppConfigurationImpl.ts Outdated Show resolved Hide resolved

src/AzureAppConfigurationImpl.ts Outdated Show resolved Hide resolved

avanigupta reviewed

View reviewed changes

src/AzureAppConfigurationImpl.ts Show resolved Hide resolved

Eskibear added 4 commits

July 29, 2024 13:09


          Merge branch 'main' of github.com:Azure/AppConfiguration-JavaScriptPr…

a3f068e

…ovider into yanzh/fm


          remove pageCount as service ensure etag changes on page add/delete

fb56a0f


          reset timer on 304, maintain refresh interval gap between attempts

b1cf809


          use empty string as placeholder when page etag is undefined, to keep …

3c12654

…the order

avanigupta approved these changes

View reviewed changes

src/AzureAppConfigurationImpl.ts Show resolved Hide resolved

Eskibear merged commit 2ce7ec6 into main

3 checks passed

Eskibear deleted the yanzh/fm branch

July 30, 2024 05:58

lorenzadomat mentioned this pull request

Potential request spamming after initial cooldown surpassed #137

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet