Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update provider version to 4.0.0-preview in AspNetCore package #186

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

abhilasharora
Copy link
Contributor

@abhilasharora abhilasharora commented Jul 20, 2020

This pull request updates the reference of the package Microsoft.Extensions.Configuration.AzureAppConfiguration to version 4.0.0-preview.

@jimmyca15
Copy link
Member

Just wanted to make sure. We're not doing a preview release of 4.0.0, we're just going straight to stable?

@abhilasharora
Copy link
Contributor Author

Just wanted to make sure. We're not doing a preview release of 4.0.0, we're just going straight to stable?

Yes, the stable version is needed to unblock the Speech Services Team.

@zhenlan
Copy link
Contributor

zhenlan commented Jul 20, 2020

I thought we were planning to release a preview first. When was the plan changed?

@abhilasharora
Copy link
Contributor Author

I thought we were planning to release a preview first. When was the plan changed?

The version upgrade to 4.0.0 stable was already done on June 18 as a part of pull request #174. This was done to ensure the Speech Services Team is unblocked. Let me know if you'd like me to exclude Refresher DI changes or JSON content type changes from this release.

@zhenlan
Copy link
Contributor

zhenlan commented Jul 20, 2020

We don't need to exclude any changes. We should do a v4 preview release first.

I see there is confusion about what the next release will be. We should start using milestones to track our releases. It helps to clarify what a release will be called and what will be included. I've created a v4.0.0-preview to get us started. Please assign issues that are addressed in upcoming release to it.

@abhilasharora abhilasharora changed the title Update provider version to 4.0.0 in AspNetCore package Update provider version to 4.0.0-preview in AspNetCore package Jul 23, 2020
@abhilasharora abhilasharora force-pushed the abarora/update-package-version branch from 94702db to dfcb31f Compare July 23, 2020 19:32
@abhilasharora abhilasharora merged commit 72e9d0e into master Jul 23, 2020
@abhilasharora abhilasharora deleted the abarora/update-package-version branch July 23, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants