Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace IConfigurationRefresher.Refresh with RefreshAsync and TryRefreshAsync methods #119

Merged
merged 2 commits into from
Feb 6, 2020
Merged

Replace IConfigurationRefresher.Refresh with RefreshAsync and TryRefreshAsync methods #119

merged 2 commits into from
Feb 6, 2020

Conversation

abhilasharora
Copy link
Contributor

This pull request contains the code changes required for issue #113.

@abhilasharora abhilasharora force-pushed the abarora/update-refresh-apis branch from bdae8bd to dd83cfb Compare February 5, 2020 23:45
@abhilasharora abhilasharora merged commit 9d6f4f2 into master Feb 6, 2020
@abhilasharora abhilasharora deleted the abarora/update-refresh-apis branch February 6, 2020 20:50
@zhenlan
Copy link
Contributor

zhenlan commented Feb 18, 2020

Just a reminder AzureAppConfigurationRefreshMiddleware.cs needs to be updated too.

@abhilasharora abhilasharora mentioned this pull request Feb 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmyca15 jimmyca15 jimmyca15 approved these changes

@zhenlan zhenlan Awaiting requested review from zhenlan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhilasharora @zhenlan @jimmyca15