Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper label for dns service ip on network tab #220

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Proper label for dns service ip on network tab #220

merged 2 commits into from
Feb 18, 2022

Conversation

jsandquist
Copy link
Contributor

PR Summary

Very minor fix in helper - change second "Service Network" label to "DNS Service IP".

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue

@Gordonby
Copy link
Collaborator

Gordonby commented Feb 18, 2022 •
edited
Loading

Looks simple enough 👍

@Gordonby Gordonby requested a review from khowling February 18, 2022 14:49
khowling
khowling approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@khowling khowling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks!

@khowling khowling merged commit 87c6282 into Azure:main Feb 18, 2022
@jsandquist jsandquist deleted the jsandquist-helper-dns-service-ip branch February 19, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khowling khowling khowling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsandquist @Gordonby @khowling