Private CICD and Bicep improvements #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to gb-repointprivatecicd
…to gb-repointprivatecicd
… gb-repointprivatecicd
…Construction into gb-repointprivatecicd
… gb-repointprivatecicd
…Construction into gb-repointprivatecicd
khowling
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR primarily targets a new GitHub environment for CI/CD of the private cluster.
A few improvements have had to be made to make this effective.
During future PR processes, we can now add a label
test-deploy-privateconfigwhich will elevate the checking that happens in the private cluster checking from validation up to full deploymentAdditional changes
Includes a few minor bicep fixes which close some recent issues.
Closes #218 (Needing subnet id's returned in the bicep output)
Closes #217 (Addressing warnings)
Removed the fragile playwright tests for the helper UI.
PR Checklist