Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open Service Mesh AddOn #200

Merged
merged 23 commits into from
Feb 11, 2022
Merged

Open Service Mesh AddOn #200

merged 23 commits into from
Feb 11, 2022

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Feb 8, 2022 •
edited
Loading

PR Summary

This simply allows OSM to be installed on the cluster.

This does not close #184 but is a pre-requisite for it.

UI

image

Refactor

Needed to refactor the AksProperties in bicep due to this error

ERROR: "error":"code":"InvalidTemplate","message":"Deployment template language expression evaluation failed: 'The language expression length limit exceeded. Limit: '81920' and actual: '149582'.'. Please see https://aka.ms/arm-template-expressions for usage details.","additionalInfo":["type":"TemplateViolation","info":"lineNumber":1049,"linePosition":5,"path":"properties.template.resources[18]"]

The conditionality used in the bicep variable AksProperties had gone over the limit. 😲😲😲😲😲🤯

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue

Gordonby and others added 14 commits February 7, 2022 11:04
Added basic OSM AddOn capability
fa79066
Adding auto compiled bicep json
225a1f2
Enable OSM in CICD for BYO
68281d0
Merge branch 'gb-osmeanble' of https://github.com/Azure/Aks-Construction
74ccf45 
 into gb-osmeanble
Added regression param file for OSM
bdabb86
disabling AzureDefender temporarily.
baf11af
Adding auto compiled bicep json
a321859
disabling security profile temporarily
f048ecd
Merge branch 'gb-osmeanble' of https://github.com/Azure/Aks-Construction
98e6b97 
 into gb-osmeanble
Adding auto compiled bicep json
f862376
Merge branch 'main' of https://github.com/Azure/Aks-Construction into…
b862281 
… gb-osmeanble
Merge branch 'gb-osmeanble' of https://github.com/Azure/Aks-Construction
0271cf5 
 into gb-osmeanble
Merge branch 'main' of https://github.com/Azure/Aks-Construction into…
809568d 
… gb-osmeanble
Added UI for OSM
ae33d09
@Gordonby Gordonby added the enhancement New feature or request label Feb 8, 2022
@Gordonby Gordonby self-assigned this Feb 8, 2022
@github-actions github-actions bot added the helper-ui 🧙‍♀️ An issue with the UI in the helper label Feb 8, 2022
@Gordonby Gordonby requested a review from khowling February 8, 2022 13:23
github-actions[bot]
github-actions bot requested changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detected parameter change

Parameter changes need to be reviewed carefully

ParameterDefaultValueFileVersion
openServiceMeshAddonfalseNew

@Gordonby Gordonby temporarily deployed to azurecirgs February 8, 2022 13:25 Inactive
@Gordonby Gordonby marked this pull request as draft February 8, 2022 14:06
@Gordonby Gordonby temporarily deployed to csu February 8, 2022 21:24 Inactive
github-actions[bot]
github-actions bot previously requested changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detected parameter change

Parameter changes need to be reviewed carefully

ParameterDefaultValueFileVersion
openServiceMeshAddonfalseNew

@Gordonby Gordonby temporarily deployed to azurecirgs February 8, 2022 21:25 Inactive
@Gordonby Gordonby temporarily deployed to azurecirgs February 8, 2022 21:26 Inactive
@Gordonby Gordonby temporarily deployed to csu February 8, 2022 21:31 Inactive
@Gordonby Gordonby temporarily deployed to csu February 8, 2022 21:32 Inactive
@Gordonby Gordonby temporarily deployed to csu February 9, 2022 09:18 Inactive
@Gordonby Gordonby temporarily deployed to azurecirgs February 9, 2022 09:19 Inactive
@Gordonby Gordonby temporarily deployed to azurecirgs February 9, 2022 09:21 Inactive
@Gordonby Gordonby temporarily deployed to csu February 9, 2022 09:23 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2022

Detected parameter change

Parameter changes need to be reviewed carefully

ParameterDefaultValueFileVersion
openServiceMeshAddonfalseNew

@Gordonby Gordonby temporarily deployed to azurecirgs February 9, 2022 09:24 Inactive
@Gordonby Gordonby dismissed github-actions[bot]’s stale review February 9, 2022 09:26

downgrading to comment from review

@Gordonby Gordonby temporarily deployed to azurecirgs February 9, 2022 10:34 Inactive
@Gordonby Gordonby temporarily deployed to azurecirgs February 9, 2022 10:38 Inactive
@Gordonby Gordonby temporarily deployed to csu February 9, 2022 12:22 Inactive
@Gordonby Gordonby temporarily deployed to azurecirgs February 9, 2022 12:23 Inactive
@Gordonby Gordonby temporarily deployed to azurecirgs February 9, 2022 12:25 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2022

Detected parameter change

Parameter changes need to be reviewed carefully

ParameterDefaultValueFileVersion
openServiceMeshAddonfalseNew

@Gordonby Gordonby changed the title Allow installation of Open Service Mesh AddOn Open Service Mesh AddOn Feb 9, 2022
@Gordonby Gordonby added the feature-flagged available via feature flag label Feb 11, 2022
@Gordonby Gordonby temporarily deployed to azurecirgs February 11, 2022 13:48 Inactive
@Gordonby Gordonby temporarily deployed to csu February 11, 2022 13:48 Inactive
@github-actions
Copy link
Contributor

Detected parameter change

Parameter changes need to be reviewed carefully

ParameterDefaultValueFileVersion
openServiceMeshAddonfalseNew

@Gordonby Gordonby temporarily deployed to csu February 11, 2022 13:51 Inactive
@github-actions
Copy link
Contributor

Detected parameter change

Parameter changes need to be reviewed carefully

ParameterDefaultValueFileVersion
openServiceMeshAddonfalseNew

@Gordonby Gordonby temporarily deployed to azurecirgs February 11, 2022 13:55 Inactive
khowling
khowling approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@khowling khowling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Gordonby Gordonby merged commit a53539b into main Feb 11, 2022
@Gordonby Gordonby deleted the gb-osmeanble branch February 11, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khowling khowling khowling approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@Gordonby Gordonby

Labels
enhancement New feature or request feature-flagged available via feature flag helper-ui 🧙‍♀️ An issue with the UI in the helper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Open Service Mesh AKS addon
2 participants
@Gordonby @khowling