Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modularise ACR Agent Pools #194

Merged
merged 7 commits into from
Feb 7, 2022
Merged

Modularise ACR Agent Pools #194

merged 7 commits into from
Feb 7, 2022

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Feb 7, 2022 •
edited
Loading

PR Summary

Fixing an issue that prevented deployment to many Azure regions #193

Also includes a few other minor improvements

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue

Closes #193

@Gordonby Gordonby self-assigned this Feb 7, 2022
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 7, 2022
@Gordonby Gordonby temporarily deployed to azurecirgs February 7, 2022 09:32 Inactive
@Gordonby Gordonby requested a review from khowling February 7, 2022 09:56
@Gordonby Gordonby added the needs-release-before-merge a preview release is required before merge to main label Feb 7, 2022
khowling
khowling previously approved these changes Feb 7, 2022
View reviewed changes
@Gordonby Gordonby temporarily deployed to azurecirgs February 7, 2022 10:10 Inactive
@Gordonby Gordonby temporarily deployed to azurecirgs February 7, 2022 10:14 Inactive
@Gordonby Gordonby requested a review from khowling February 7, 2022 10:19
@Gordonby Gordonby removed the needs-release-before-merge a preview release is required before merge to main label Feb 7, 2022
@Gordonby Gordonby merged commit 6086eea into main Feb 7, 2022
@Gordonby Gordonby deleted the gb-littlefixes branch February 7, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khowling khowling khowling approved these changes

Assignees

@Gordonby Gordonby

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ACR Agent Pools - Conditionality issue.
2 participants
@Gordonby @khowling