Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helper Updates #189

Merged
merged 20 commits into from
Feb 17, 2022
Merged

Helper Updates #189

merged 20 commits into from
Feb 17, 2022

Conversation

khowling
Copy link
Contributor

@khowling khowling commented Jan 23, 2022 •
edited
Loading

PR Summary

  • Helper - Update react-scripts to 5.0.0, to remove the dependency warnings
  • Helper - Implement Dark mode support
  • Addons tab - re-org, raise registry and ingress to top before monitoring
  • Addons tab - Add Grafana public Ingress option with DNS and TLS addons.enableMonitorIngress
  • Deploy tab - Display the template release version in a Dropdown. NOTE: This is defaulted to the value of the build env var REACT_APP_TEMPLATERELEASE, If this is set, the template version will also be non-changeable. (this replaces the old REACT_APP_AZ_TEMPLATE_ARG)
  • Deploy tab - Provided a option to select 'Local' template version, this will use the local files when running the deploy and post-deploy scripts from the UI - very useful for testing on a locally cloned repo
  • Deploy tab - Refactor the post deployment scripts to:
    • Provide support for running scripts locally
    • Use new external-dns helm package
    • Simplify the cert-manager post script, using the local helm package for the issuers. NOTE: currently just using main branch for networkpolicy-deny-all.yml & Az-CertManagerIssuer-0.3.0.tgz. Need to add these files to the release
    • Use a single az aks invoke command call for all the post script helm/kubectl commands (private clusters)
  • Move java sample app to https://github.com/Azure-Samples/java-aks-keyvault-tls

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue

@github-actions github-actions bot added the helper-ui 🧙‍♀️ An issue with the UI in the helper label Jan 23, 2022
@khowling khowling temporarily deployed to azurecirgs January 26, 2022 20:34 Inactive
@khowling khowling temporarily deployed to azurecirgs February 15, 2022 17:55 Inactive
@khowling khowling marked this pull request as ready for review February 16, 2022 19:28
@khowling khowling requested a review from Gordonby February 16, 2022 19:28
@khowling khowling temporarily deployed to azurecirgs February 17, 2022 11:06 Inactive
@Gordonby
Copy link
Collaborator

Can you bump the K8S version to 1.21.9 - which is now the portal default. 👍
image

@khowling khowling temporarily deployed to azurecirgs February 17, 2022 11:45 Inactive
@khowling khowling temporarily deployed to csu February 17, 2022 11:45 Inactive
@khowling khowling temporarily deployed to azurecirgs February 17, 2022 11:45 Inactive
@github-actions
Copy link
Contributor

Detected parameter change

Parameter changes need to be reviewed carefully

ParameterDefaultValueFileVersion
kubernetesVersion"1.21.7"Old
kubernetesVersion"1.21.9"New

@khowling khowling temporarily deployed to csu February 17, 2022 11:48 Inactive
@khowling khowling temporarily deployed to azurecirgs February 17, 2022 11:48 Inactive
@github-actions
Copy link
Contributor

Detected parameter change

Parameter changes need to be reviewed carefully

ParameterDefaultValueFileVersion
kubernetesVersion"1.21.7"Old
kubernetesVersion"1.21.9"New

@Gordonby
Copy link
Collaborator

Can you add a link back to the Github release?
image

@Gordonby
Copy link
Collaborator

Should we show disabled, rather than make invisible.
image

Gordonby
Gordonby approved these changes Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@Gordonby Gordonby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khowling khowling merged commit 4870e71 into main Feb 17, 2022
@khowling khowling deleted the kh-commonscripts branch February 17, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gordonby Gordonby Gordonby approved these changes

Assignees
No one assigned
Labels
helper-ui 🧙‍♀️ An issue with the UI in the helper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khowling @Gordonby