Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java sample App refactor #187

Merged
merged 29 commits into from
Jan 20, 2022
Merged

Java sample App refactor #187

merged 29 commits into from
Jan 20, 2022

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Jan 20, 2022

PR Summary

Utilising the Java App on Azure-Samples/ repo for installation of the Java Sample app.

Added a new stage to the BYO CI/CD GitHub action for post deploy steps (CertManager / ExternalDNS).

Added the helm packages for CertManager Issuer and ExternalDNS to this repo.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue

@Gordonby Gordonby added the enhancement New feature or request label Jan 20, 2022
@Gordonby Gordonby requested a review from khowling January 20, 2022 12:07
@Gordonby Gordonby self-assigned this Jan 20, 2022
@github-actions github-actions bot added the helper-ui 🧙‍♀️ An issue with the UI in the helper label Jan 20, 2022
@Gordonby Gordonby temporarily deployed to azurecirgs January 20, 2022 12:12 Inactive
Copy link
Contributor

@khowling khowling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent!

@Gordonby Gordonby temporarily deployed to azurecirgs January 20, 2022 12:30 Inactive
@Gordonby Gordonby added the ci-cd sample 🤖 Sample code in a GitHub action workflow label Jan 20, 2022
@Gordonby Gordonby merged commit 1ec463b into main Jan 20, 2022
@Gordonby Gordonby deleted the gb-certmanagerrefactor branch January 20, 2022 12:38
@Gordonby Gordonby restored the gb-certmanagerrefactor branch January 20, 2022 20:33
@Gordonby Gordonby deleted the gb-certmanagerrefactor branch January 21, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd sample 🤖 Sample code in a GitHub action workflow enhancement New feature or request helper-ui 🧙‍♀️ An issue with the UI in the helper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants