Made akvName contain random string

[aszego]

PR Summary

Key Vault's name must be unique across Azure, and previous naming didn't contain a call to uniquestring().
I use the same implementation as with acrName.

PR Checklist

• PR has a meaningful title
• Summarized changes
• This PR is ready to merge and is not Work in Progress
• Link to a filed issue

[github-actions]

Thank you for the contribution, one of the team will evaluate shortly.

[Gordonby]

Can you run the bicep build action in your repo to generate the compiled bicep please?
We'll need this as part of the PR, otherwise things get out of sync.

[Gordonby]

resourceName can be up to 20 characters in length.

Key Vault has a limit of 24 characters for its name.

This means by adding UniqueString() as a suffix, we're going to run this risk of going over the limit. We should ensure that we don't go over 24 characters.

I think you'll need something like this..

var akvRawName = 'kv-${replace(resourceName, '-', '')}${uniqueString(resourceGroup().id, resourceName)}'
var akvName = length(akvRawName) > 24 ? substring(akvRawName ,0,23) : akvRawName

@aszego - thoughts?

[Gordonby]

Fixed up PR;

• Updating from main
• Resolved conflicts
• Tested KV name creation/truncation

Looks good.