Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BicepBuild workflow - Powershell bug #171

Merged
merged 1 commit into from
Dec 21, 2021
Merged

BicepBuild workflow - Powershell bug #171

merged 1 commit into from
Dec 21, 2021

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Dec 21, 2021

PR Summary

Fixing an issue with the PowerShell whereby the Parameter comparison output was incorrect. A parameter name was being chose seemingly at random.

Example 1

Inspect the comment history in #168

Example 2

Taken from #167

Incorrect

Detected parameter change

Parameter changes need to be reviewed carefully

ParameterDefaultValueFileVersion
adminprincipleid""New

Correct

Detected parameter change

Parameter changes need to be reviewed carefully

ParameterDefaultValueFileVersion
inboundHttpFW""New

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue

@Gordonby Gordonby self-assigned this Dec 21, 2021
@Gordonby Gordonby added the bug Something isn't working label Dec 21, 2021
@Gordonby Gordonby merged commit 78a4d91 into main Dec 21, 2021
@Gordonby Gordonby deleted the gb-bicepbuildbug branch December 21, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant