Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy post deploy & import externaldns container #166

Merged
merged 1 commit into from
Dec 20, 2021
Merged

tidy post deploy & import externaldns container #166

merged 1 commit into from
Dec 20, 2021

Conversation

khowling
Copy link
Contributor

@khowling khowling commented Dec 20, 2021

PR Summary

  • Tidy up the post-deploy script, with comments
  • If using external-dns with private cluster, import the external-dns image to the ACR

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue

@github-actions github-actions bot added the helper-ui 🧙‍♀️ An issue with the UI in the helper label Dec 20, 2021
@khowling khowling requested a review from Gordonby December 20, 2021 12:53
@khowling
Copy link
Contributor Author

this means dont need to whitelist k8s.gcr.io in the firewall, I should really to the same with cert-manager & quay.io in a later PR @Gordonby

@Gordonby
Copy link
Collaborator

Gordonby commented Dec 20, 2021

Looks ok.
image

Think we need to move to using helm charts instead of string splitting for future.

Have a look at the two relevant ones i created. They are used in the GitHub actions already.
https://github.com/Gordonby/minihelm/tree/main/samples
Perhaps we can add a backlog item to shift to helm.

Copy link
Collaborator

@Gordonby Gordonby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khowling khowling merged commit a50ed0b into main Dec 20, 2021
@khowling khowling deleted the kh-extdns branch December 20, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helper-ui 🧙‍♀️ An issue with the UI in the helper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants