Skip to content

Commit

Permalink
+ primary ctors
Browse files Browse the repository at this point in the history
  • Loading branch information
Charles Torre committed May 8, 2024
1 parent 083fc9b commit 7f72b86
Show file tree
Hide file tree
Showing 9 changed files with 27 additions and 79 deletions.
17 changes: 6 additions & 11 deletions src/GettingStartedApplication/ActorBackendServiceV2/MyActor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,22 +20,17 @@ namespace ActorBackendService
/// - Volatile: State is kept in memory only and replicated.
/// - None: State is kept in memory only and not replicated.
/// </remarks>
/// <summary>
/// Initializes a new instance of ActorBackendService
/// </summary>
/// <param name="actorService">The Microsoft.ServiceFabric.Actors.Runtime.ActorService that will host this actor instance.</param>
/// <param name="actorId">The Microsoft.ServiceFabric.Actors.ActorId for this actor instance.</param>
[StatePersistence(StatePersistence.Persisted)]
internal class MyActor : Actor, IMyActor, IRemindable
internal class MyActor(ActorService actorService, ActorId actorId) : Actor(actorService, actorId), IMyActor, IRemindable
{
private const string ReminderName = "Reminder";
private const string StateName = "Count";

/// <summary>
/// Initializes a new instance of ActorBackendService
/// </summary>
/// <param name="actorService">The Microsoft.ServiceFabric.Actors.Runtime.ActorService that will host this actor instance.</param>
/// <param name="actorId">The Microsoft.ServiceFabric.Actors.ActorId for this actor instance.</param>
public MyActor(ActorService actorService, ActorId actorId)
: base(actorService, actorId)
{
}

public async Task StartProcessingAsync(CancellationToken cancellationToken)
{
try
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,10 @@
namespace StatefulBackendService.Controllers
{
[Route("api/[controller]")]
public class ValuesController : Controller
public class ValuesController(IReliableStateManager stateManager) : Controller
{
private static readonly Uri ValuesDictionaryName = new("store:/values");
private readonly IReliableStateManager stateManager;

public ValuesController(IReliableStateManager stateManager)
{
this.stateManager = stateManager;
}
private readonly IReliableStateManager stateManager = stateManager;

// GET api/values
[HttpGet]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,8 @@ namespace StatefulBackendService
/// <summary>
/// The FabricRuntime creates an instance of this class for each service type instance.
/// </summary>
internal sealed class StatefulBackendService : StatefulService
internal sealed class StatefulBackendService(StatefulServiceContext context) : StatefulService(context)
{
public StatefulBackendService(StatefulServiceContext context)
: base(context)
{
}

/// <summary>
/// Optional override to create listeners (like tcp, http) for this service instance.
/// </summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,10 @@ namespace StatelessBackendService
/// <summary>
/// An instance of this class is created for each service instance by the Service Fabric runtime.
/// </summary>
internal sealed class StatelessBackendService : StatelessService, IStatelessBackendService
internal sealed class StatelessBackendService(StatelessServiceContext context) : StatelessService(context), IStatelessBackendService
{
private long iterations = 0;

public StatelessBackendService(StatelessServiceContext context)
: base(context)
{
}

public Task<long> GetCountAsync() => Task.FromResult(iterations);

/// <summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,11 @@
namespace WebService.Controllers
{
[Route("api/[controller]")]
public class ActorBackendServiceController : Controller
public class ActorBackendServiceController(StatelessServiceContext serviceContext, ConfigSettings settings, FabricClient fabricClient) : Controller
{
private readonly FabricClient fabricClient;
private readonly ConfigSettings configSettings;
private readonly StatelessServiceContext serviceContext;

public ActorBackendServiceController(StatelessServiceContext serviceContext, ConfigSettings settings, FabricClient fabricClient)
{
this.serviceContext = serviceContext;
configSettings = settings;
this.fabricClient = fabricClient;
}
private readonly FabricClient fabricClient = fabricClient;
private readonly ConfigSettings configSettings = settings;
private readonly StatelessServiceContext serviceContext = serviceContext;

// GET: api/actorbackendservice
[HttpGet]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,11 @@
namespace WebService.Controllers
{
[Route("api/[controller]")]
public class GuestExeBackendServiceController : Controller
public class GuestExeBackendServiceController(StatelessServiceContext serviceContext, HttpClient httpClient, FabricClient fabricClient, ConfigSettings settings) : Controller
{
private readonly HttpClient httpClient;
private readonly StatelessServiceContext serviceContext;
private readonly ConfigSettings configSettings;

public GuestExeBackendServiceController(StatelessServiceContext serviceContext, HttpClient httpClient, FabricClient fabricClient, ConfigSettings settings)
{
this.serviceContext = serviceContext;
this.httpClient = httpClient;
configSettings = settings;
}
private readonly HttpClient httpClient = httpClient;
private readonly StatelessServiceContext serviceContext = serviceContext;
private readonly ConfigSettings configSettings = settings;

// GET: api/values
[HttpGet]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,20 +17,12 @@
namespace WebService.Controllers
{
[Route("api/[controller]")]
public class StatefulBackendServiceController : Controller
public class StatefulBackendServiceController(StatelessServiceContext serviceContext, HttpClient httpClient, FabricClient fabricClient, ConfigSettings settings) : Controller
{
private readonly HttpClient httpClient;
private readonly StatelessServiceContext serviceContext;
private readonly ConfigSettings configSettings;
private readonly FabricClient fabricClient;

public StatefulBackendServiceController(StatelessServiceContext serviceContext, HttpClient httpClient, FabricClient fabricClient, ConfigSettings settings)
{
this.serviceContext = serviceContext;
this.httpClient = httpClient;
configSettings = settings;
this.fabricClient = fabricClient;
}
private readonly HttpClient httpClient = httpClient;
private readonly StatelessServiceContext serviceContext = serviceContext;
private readonly ConfigSettings configSettings = settings;
private readonly FabricClient fabricClient = fabricClient;

// GET: api/values
[HttpGet]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,10 @@
namespace WebService.Controllers
{
[Route("api/[controller]")]
public class StatelessBackendServiceController : Controller
public class StatelessBackendServiceController(StatelessServiceContext serviceContext, ConfigSettings settings) : Controller
{
private readonly ConfigSettings configSettings;
private readonly StatelessServiceContext serviceContext;

public StatelessBackendServiceController(StatelessServiceContext serviceContext, ConfigSettings settings)
{
this.serviceContext = serviceContext;
configSettings = settings;
}
private readonly ConfigSettings configSettings = settings;
private readonly StatelessServiceContext serviceContext = serviceContext;

// GET: api/values
[HttpGet]
Expand Down
6 changes: 1 addition & 5 deletions src/GettingStartedApplication/WebService/WebService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,8 @@ namespace WebService
/// <summary>
/// The FabricRuntime creates an instance of this class for each service type instance.
/// </summary>
internal sealed class WebService : StatelessService
internal sealed class WebService(StatelessServiceContext context) : StatelessService(context)
{
public WebService(StatelessServiceContext context)
: base(context)
{
}

/// <summary>
/// Optional override to create listeners (like tcp, http) for this service instance.
Expand Down

0 comments on commit 7f72b86

Please sign in to comment.