Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Unnecessary Checks when Switching Local Camera #79

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Remove Unnecessary Checks when Switching Local Camera #79

merged 1 commit into from
Jul 14, 2021

Conversation

Gemakk
Copy link
Contributor

@Gemakk Gemakk commented Jul 7, 2021 •
edited by waynemo
Loading

Purpose

  • Remove unnecessary logic for checking for a call object and starting the video

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

What to Check

Verify that the following are valid

  • Ensure switching local camera is functioning on both Setup and Call screens

@Gemakk Gemakk requested review from a team as code owners July 7, 2021 21:19
iaulakh
iaulakh approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@iaulakh iaulakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

@Gemakk Gemakk mentioned this pull request Jul 9, 2021
Merged
@waynemo waynemo changed the title Don't call startVideo if you've already called switchSource Remove Unnecessary Checks when Switching Local Camera Jul 13, 2021
@Gemakk Gemakk merged commit 81fee0f into main Jul 14, 2021
@Gemakk Gemakk deleted the user/yukonchen/fix-switch-camera-working-after-denied-teams-meeting-main branch July 14, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynemo waynemo waynemo approved these changes

@iaulakh iaulakh iaulakh approved these changes

@palatter palatter Awaiting requested review from palatter

@AmyL219 AmyL219 Awaiting requested review from AmyL219

@lpeixin lpeixin Awaiting requested review from lpeixin

@cheukchuen cheukchuen Awaiting requested review from cheukchuen

@pavelprystinka pavelprystinka Awaiting requested review from pavelprystinka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gemakk @waynemo @iaulakh