Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fetch master for DSL recursion #381

Closed
wants to merge 5 commits into from

Conversation

vezenovm
Copy link
Contributor

@vezenovm vezenovm commented Apr 25, 2023

Description

The noir-recursion branch requires more changes from master that Noir also requires

There was a change in the recursion work that removed the reference string from the std lib verification key which required usage of the env crs. However, any usage of env_load_prover_crs or env_load_verifier_crs fails on mainframe due to undefined reference to bbmalloc'` (oddly enough it all works on my local macbook). This branch also includes a workaround to get EnvReferenceString compiling by just calling aligned_alloc which bbmalloc calls internally. However, I don't know if this possibly breaks things elsewhere in wasm. Otherwise we may have to go back to storing the reference string inside the stdlib verification key, or nail down why we are getting an undefined reference when linking on linux.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /markdown/specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

@vezenovm vezenovm marked this pull request as ready for review April 25, 2023 18:40
@vezenovm vezenovm mentioned this pull request Apr 25, 2023
11 tasks
@vezenovm
Copy link
Contributor Author

vezenovm commented Apr 25, 2023

Closing in favor of mv/noir-recursion. Don't squash the branch just yet though as mv/noir-recursion merges this branch into zw/noir-recursion

@vezenovm vezenovm closed this Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant