feat: Client ivc proof verification in sequencer

[spalladino]

Wires the verify_client_ivc bb call to the BBVerifier in ts (which still needs love so we don't read the vk from the tx object), and runs it multiple times as part of the full prover e2e to benchmark how much it takes to verify a client ivc proof. Outputs event logs like the following, though they are not yet loaded by bench-aggregate:

{"circuitName":"private-kernel-tail-to-public","duration":3640.18761600001,"eventName":"circuit-verification","level":"debug","message":"ClientIVC verification successful","namespace":"aztec:bb-verifier","proofType":"client-ivc","timestamp":"2024-07-22T19:37:19.785Z"}
{"circuitName":"private-kernel-tail","duration":3630.627105999971,"eventName":"circuit-verification","level":"debug","message":"ClientIVC verification successful","namespace":"aztec:bb-verifier","proofType":"client-ivc","timestamp":"2024-07-22T19:37:23.419Z"}
{"circuitName":"private-kernel-tail-to-public","duration":3636.371545000002,"eventName":"circuit-verification","level":"debug","message":"ClientIVC verification successful","namespace":"aztec:bb-verifier","proofType":"client-ivc","timestamp":"2024-07-22T19:37:27.057Z"}
{"circuitName":"private-kernel-tail","duration":3561.3480010000058,"eventName":"circuit-verification","level":"debug","message":"ClientIVC verification successful","namespace":"aztec:bb-verifier","proofType":"client-ivc","timestamp":"2024-07-22T19:37:30.620Z"}
{"circuitName":"private-kernel-tail-to-public","duration":3588.0015310000163,"eventName":"circuit-verification","level":"debug","message":"ClientIVC verification successful","namespace":"aztec:bb-verifier","proofType":"client-ivc","timestamp":"2024-07-22T19:37:34.211Z"}
{"circuitName":"private-kernel-tail","duration":3610.198040999996,"eventName":"circuit-verification","level":"debug","message":"ClientIVC verification successful","namespace":"aztec:bb-verifier","proofType":"client-ivc","timestamp":"2024-07-22T19:37:37.824Z"}
{"circuitName":"private-kernel-tail-to-public","duration":3569.164287999971,"eventName":"circuit-verification","level":"debug","message":"ClientIVC verification successful","namespace":"aztec:bb-verifier","proofType":"client-ivc","timestamp":"2024-07-22T19:37:41.396Z"}
{"circuitName":"private-kernel-tail","duration":3557.741927999945,"eventName":"circuit-verification","level":"debug","message":"ClientIVC verification successful","namespace":"aztec:bb-verifier","proofType":"client-ivc","timestamp":"2024-07-22T19:37:44.955Z"}
{"circuitName":"private-kernel-tail-to-public","duration":3568.2085040000384,"eventName":"circuit-verification","level":"debug","message":"ClientIVC verification successful","namespace":"aztec:bb-verifier","proofType":"client-ivc","timestamp":"2024-07-22T19:37:48.526Z"}
{"circuitName":"private-kernel-tail","duration":3557.740408999962,"eventName":"circuit-verification","level":"debug","message":"ClientIVC verification successful","namespace":"aztec:bb-verifier","proofType":"client-ivc","timestamp":"2024-07-22T19:37:52.088Z"}
{"circuitName":"private-kernel-tail-to-public","duration":3568.786586000002,"eventName":"circuit-verification","level":"debug","message":"ClientIVC verification successful","namespace":"aztec:bb-verifier","proofType":"client-ivc","timestamp":"2024-07-22T19:37:55.659Z"}
{"circuitName":"private-kernel-tail","duration":3559.4025660000043,"eventName":"circuit-verification","level":"debug","message":"ClientIVC verification successful","namespace":"aztec:bb-verifier","proofType":"client-ivc","timestamp":"2024-07-22T19:37:59.221Z"}
{"circuitName":"private-kernel-tail-to-public","duration":3567.728372999991,"eventName":"circuit-verification","level":"debug","message":"ClientIVC verification successful","namespace":"aztec:bb-verifier","proofType":"client-ivc","timestamp":"2024-07-22T19:38:02.792Z"}
{"circuitName":"private-kernel-tail","duration":3566.036272999947,"eventName":"circuit-verification","level":"debug","message":"ClientIVC verification successful","namespace":"aztec:bb-verifier","proofType":"client-ivc","timestamp":"2024-07-22T19:38:06.362Z"}
{"circuitName":"private-kernel-tail-to-public","duration":3569.9772229999653,"eventName":"circuit-verification","level":"debug","message":"ClientIVC verification successful","namespace":"aztec:bb-verifier","proofType":"client-ivc","timestamp":"2024-07-22T19:38:09.935Z"}
{"circuitName":"private-kernel-tail","duration":3561.0968479999574,"eventName":"circuit-verification","level":"debug","message":"ClientIVC verification successful","namespace":"aztec:bb-verifier","proofType":"client-ivc","timestamp":"2024-07-22T19:38:13.499Z"}
{"circuitName":"private-kernel-tail-to-public","duration":3569.0639850000152,"eventName":"circuit-verification","level":"debug","message":"ClientIVC verification successful","namespace":"aztec:bb-verifier","proofType":"client-ivc","timestamp":"2024-07-22T19:38:17.071Z"}
{"circuitName":"private-kernel-tail","duration":3562.8168169999844,"eventName":"circuit-verification","level":"debug","message":"ClientIVC verification successful","namespace":"aztec:bb-verifier","proofType":"client-ivc","timestamp":"2024-07-22T19:38:20.639Z"}
{"circuitName":"private-kernel-tail-to-public","duration":3568.064185999974,"eventName":"circuit-verification","level":"debug","message":"ClientIVC verification successful","namespace":"aztec:bb-verifier","proofType":"client-ivc","timestamp":"2024-07-22T19:38:24.209Z"}
{"circuitName":"private-kernel-tail","duration":3558.7975469999947,"eventName":"circuit-verification","level":"debug","message":"ClientIVC verification successful","namespace":"aztec:bb-verifier","proofType":"client-ivc","timestamp":"2024-07-22T19:38:27.771Z"}
{"circuitName":"private-kernel-tail","duration":3616.5346459999564,"eventName":"circuit-verification","level":"debug","message":"ClientIVC verification successful","namespace":"aztec:bb-verifier","proofType":"client-ivc","timestamp":"2024-07-22T19:38:31.404Z"}

[spalladino]

Flagging PR as ready for review, but I've had previous runs where the ClientIVC verification failed randomly (see here for a run where one tx succeeded but the other failed, or here for a run for the e2e_prover that worked when re-run). I haven't been able to reproduce it again though. Is it possible that either proof generation or verification for ClientIVC is flaky?

[AztecBot]

Benchmark results

Metrics with a significant change:

• protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 4,027 (-19%)
• avm_simulation_time_ms (Token:transfer_public): 45.5 (+33%)
• avm_simulation_time_ms (Token:_increase_public_balance): 160 (+759%)
• avm_simulation_time_ms (FPC:pay_refund_with_shielded_rebate): 107 (-39%)
• protocol_circuit_proving_time_in_ms (base-parity): 1,941 (+46%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,725	1,541	707	743 (-2%)	774
proof_construction_time_sha256_30_ms	11,734	3,177 (+1%)	1,417	1,431 (-1%)	1,463 (-1%)
proof_construction_time_sha256_100_ms	43,803	11,975 (+1%)	5,461	5,473 (+2%)	5,393 (+1%)
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0 (-21%)	60.0 (-8%)	90.0
proof_construction_time_poseidon_hash_30_ms	1,517	416	201 (+1%)	229 (-2%)	269
proof_construction_time_poseidon_hash_100_ms	5,618	1,513	681	728 (+1%)	749

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	708	708	708
l1_rollup_calldata_gas	6,588	6,590	6,600
l1_rollup_execution_gas	583,050	583,203	583,364
l2_block_processing_time_in_ms	765 (+2%)	1,418 (-1%)	2,711 (-1%)
l2_block_building_time_in_ms	13,183	25,396 (-1%)	50,985
l2_block_rollup_simulation_time_in_ms	13,182	25,396 (-1%)	50,985
l2_block_public_tx_process_time_in_ms	11,034	23,102 (-1%)	48,609

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,041 (-1%)	9,850 (-1%)
node_database_size_in_bytes	12,709,968	16,867,408
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	115	441 (+7%)	21,732	54,085	N/A	N/A	N/A	N/A
private-kernel-inner	227 (-8%)	773 (+4%)	81,199	54,264	N/A	N/A	N/A	N/A
private-kernel-tail	1,115 (-1%)	2,553 (+3%)	61,568	62,127	N/A	N/A	N/A	N/A
base-parity	6.58 (+1%)	839 (+2%)	160	96.0	⚠️ 1,941 (+46%)	12,676	3.00	131,072
root-parity	107 (-2%)	107 (-12%)	64,860	96.0	27,877 (-1%)	12,676	3.00	4,194,304
base-rollup	4,178 (-1%)	5,125 (-1%)	181,083	632	40,784 (-1%)	13,476	28.0	4,194,304
root-rollup	154	111 (-1%)	51,261	652	25,411	13,412	26.0	4,194,304
public-kernel-setup	197	2,361	113,048	80,822	15,740	119,428	3,339	2,097,152
public-kernel-app-logic	150 (-1%)	3,332	113,048	80,822	8,793 (+1%)	119,428	3,339	1,048,576
public-kernel-tail	890 (-1%)	26,318 (+11%)	410,181	10,814	62,394 (+1%)	25,860	415	8,388,608
private-kernel-reset-tiny	308 (+4%)	1,049 (+1%)	77,007	53,954	N/A	N/A	N/A	N/A
private-kernel-tail-to-public	⚠️ 4,027 (-19%)	2,975 (+2%)	773,262	1,632	N/A	N/A	N/A	N/A
public-kernel-teardown	141	3,303	113,048	80,822	16,348 (+1%)	119,428	3,339	2,097,152
merge-rollup	57.3 (-1%)	N/A	33,566	632	N/A	N/A	N/A	N/A
undefined	N/A	N/A	N/A	N/A	173,423	N/A	N/A	N/A

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms
ContractClassRegisterer:register	1,312	9,344	390 (-2%)	N/A	N/A
ContractInstanceDeployer:deploy	1,376	9,344	25.6 (+1%)	N/A	N/A
MultiCallEntrypoint:entrypoint	1,888	9,344	640	N/A	N/A
GasToken:deploy	1,344	9,344	568 (-5%)	N/A	N/A
SchnorrAccount:constructor	1,280	9,344	468	N/A	N/A
SchnorrAccount:entrypoint	2,272	9,344	795 (-1%)	N/A	N/A
Token:privately_mint_private_note	1,248	9,344	567 (+1%)	N/A	N/A
FPC:fee_entrypoint_public	1,312	9,344	106 (+2%)	N/A	N/A
Token:transfer	1,280	9,344	1,540	N/A	N/A
AuthRegistry:set_authorized (avm)	19,222	N/A	N/A	95,392	2,340 (-4%)
FPC:prepare_fee (avm)	22,670	N/A	N/A	95,456	2,422 (-2%)
Token:transfer_public (avm)	42,914	N/A	N/A	95,456	3,208 (+2%)
AuthRegistry:consume (avm)	33,100	N/A	N/A	95,424	2,985 (+4%)
FPC:pay_refund (avm)	32,835	N/A	N/A	95,424	8,055 (-1%)
Benchmarking:create_note	1,312	9,344	442 (-3%)	N/A	N/A
SchnorrAccount:verify_private_authwit	1,248	9,344	42.1 (+2%)	N/A	N/A
Token:unshield	1,344	9,344	1,218	N/A	N/A
FPC:fee_entrypoint_private	1,344	9,344	1,607	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	98.0 (-2%)	13,790
GasToken:set_portal	11.3 (-1%)	3,339
Token:constructor	124	23,692
FPC:constructor	92.8 (-1%)	13,592
GasToken:mint_public	81.7 (-1%)	10,158
Token:mint_public	61.1 (+5%)	19,034
Token:assert_minter_and_mint	73.3 (+4%)	12,925
AuthRegistry:set_authorized	45.3 (+2%)	7,812
FPC:prepare_fee	111 (+8%)	11,068
Token:transfer_public	⚠️ 45.5 (+33%)	31,218
FPC:pay_refund	125 (+2%)	21,266
Benchmarking:increment_balance	1,293 (-1%)	11,281
Token:_increase_public_balance	⚠️ 160 (+759%)	15,006
FPC:pay_refund_with_shielded_rebate	⚠️ 107 (-39%)	22,361

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.152

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.4	16.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.603	0.518	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	48.4	76.2 (+1%)	132 (+1%)	246	469
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.495	0.468 (+1%)	0.455 (+1%)	0.445	0.439
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	60.1 (+1%)	111	183 (+1%)	353	692
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.508 (+1%)	0.500	0.484 (+1%)	0.479	0.477
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	73.0	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.519	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	77,362	668,542

Transaction size based on fee payment method

| Metric | |
| - | |