Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sync from noir #6023

Merged
merged 4 commits into from
Apr 25, 2024
Merged

feat: Sync from noir #6023

merged 4 commits into from
Apr 25, 2024

Conversation

AztecBot
Copy link
Collaborator

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore: rework workspace structure for utils crates (noir-lang/noir#4886)
feat: add variable size sha256 (noir-lang/noir#4920)
chore: delete flake.lock (noir-lang/noir#4855)
chore: Add error conversion from InterpreterError (noir-lang/noir#4896)
chore: delete dead code (noir-lang/noir#4906)
END_COMMIT_OVERRIDE

AztecBot and others added 3 commits April 25, 2024 16:15
…lang/noir#4886)

feat: add variable size sha256 (noir-lang/noir#4920)
chore: delete flake.lock (noir-lang/noir#4855)
chore: Add error conversion from `InterpreterError` (noir-lang/noir#4896)
chore: delete dead code (noir-lang/noir#4906)
* master: (30 commits)
  chore: run noir projects tests in earthly (#6024)
  feat: add key registry to deployment (e2e & sandbox) (#5875)
  fix(docs): Fix admonition in contract class protocol spec (#6017)
  chore: lift run-e2e to yarn-project earthfile (#6018)
  chore!: remove `Opcode::Brillig` from ACIR (#5995)
  chore(ci): Reenable deploy tests (#6011)
  refactor: improved naming in `TxExecutionRequest` (#6014)
  test: extend SharedMutable tests (#6005)
  fix: bigint corruption in lmdb (#6002)
  chore: rename capture to end_setup (#6008)
  feat: AES oracle padding (#6013)
  refactor: replace queue with facade over CircuitProver (#5972)
  chore(ci): fix concurrency key (#5962)
  chore(ci): prevent haywire logs (#5966)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  docs: Aztec smart contract tutorial - crowdfunding (#5786)
  feat: Wire gas from public execution to kernels (#5941)
  ...
@TomAFrench TomAFrench enabled auto-merge (squash) April 25, 2024 18:23
@AztecBot
Copy link
Collaborator Author

Benchmark results

Metrics with a significant change:

  • note_trial_decrypting_time_in_ms (32): 75.0 (+299%)
  • note_trial_decrypting_time_in_ms (64): 77.0 (+225%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 772 772 772
l1_rollup_calldata_gas 6,820 6,820 6,820
l1_rollup_execution_gas 587,301 587,301 587,301
l2_block_processing_time_in_ms 1,575 (+8%) 5,492 (+5%) 10,502 (+1%)
note_successful_decrypting_time_in_ms 204 (+3%) 573 (+11%) 1,147 (+7%)
note_trial_decrypting_time_in_ms 95.3 (+12%) ⚠️ 75.0 (+299%) ⚠️ 77.0 (+225%)
l2_block_building_time_in_ms 18,661 72,676 (-1%) 144,678 (-1%)
l2_block_rollup_simulation_time_in_ms 18,450 71,930 (-1%) 143,222 (-1%)
l2_block_public_tx_process_time_in_ms 8,434 33,034 (-1%) 66,036 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 16,477 (+5%) 33,241 (+12%)
note_history_successful_decrypting_time_in_ms 1,334 (-5%) 2,653 (-2%)
note_history_trial_decrypting_time_in_ms 127 (+13%) 65.7 (-39%)
node_database_size_in_bytes 20,721,744 (+8%) 37,638,224 (+5%)
pxe_database_size_in_bytes 29,868 59,425

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 156 (-1%) 47,763 31,978
private-kernel-inner 176 (-1%) 80,794 31,978
private-kernel-ordering 136 (-1%) 57,732 49,313 (-1%)
base-parity 9.38 128 265
root-parity 65.5 (-13%) 1,244 265
base-rollup 11,543 (-4%) 110,926 957
root-rollup 49.7 4,551 821
public-kernel-app-logic 1,560 62,017 26,202
public-kernel-tail 4,281 (+1%) 168,566 3,812
merge-rollup 3,198 2,760 957
public-kernel-teardown 120 (+1%) 62,017 34,711
public-kernel-setup 131 (-2%) 62,017 34,711

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 11.1 18.1 (+3%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.7 31.8 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.649 (+1%) 0.557 (+2%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 52.3 (+2%) 79.8 (-1%) 260 522 (+4%) 978 (-1%) 1,940 N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.535 (+2%) 0.493 (-1%) 0.474 0.488 (+4%) 0.465 (-1%) 0.464 N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 61.4 (+2%) 119 375 (+1%) 800 (+8%) 1,461 2,903 N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 105 208 692 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.542 (+2%) 0.538 0.509 0.553 (+9%) 0.506 0.506 N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 69.2 (+3%)
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 108 (-1%)
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.609 (+4%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 51,411 536,920 (-1%)

Transaction size based on fee payment method

Metric native fee payment method fpc_public fee payment method fpc_private fee payment method
tx_with_fee_size_in_bytes 897 1,145 1,345

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes 2 new note hashes
tx_pxe_processing_time_ms 1,228 (-2%) 856 (-1%) 3,486 (-2%)
Metric 1 public data writes 2 public data writes 3 public data writes 4 public data writes 5 public data writes 8 public data writes
tx_sequencer_processing_time_ms 854 (+2%) 759 (-1%) 1,357 (-1%) 898 (-2%) 2,082 (-1%) 1,081 (-1%)

@TomAFrench TomAFrench merged commit 078aa61 into master Apr 25, 2024
53 of 56 checks passed
@TomAFrench TomAFrench deleted the sync-noir branch April 25, 2024 22:19
ludamad added a commit that referenced this pull request Apr 25, 2024
ludamad added a commit that referenced this pull request Apr 25, 2024
Reverts #6023

@TomAFrench this was failing, not sure how it got merged?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants