Archiver #41
Merged
Archiver #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11dfbb3 to
ba6ddde
Compare
LHerskind
reviewed
Mar 16, 2023
| * The data that makes up the rollup proof, with encoder decoder functions. | ||
| */ | ||
| export class L2Block { | ||
| public yeet?: Buffer; |
There was a problem hiding this comment.
What is the purpose of having a yeet on the block? Is this to be set to all data yeeted in the block or what is the reasoning? Please comment it. Also, there can be multiple yeets for one block, so it might need some clarification there.
There was a problem hiding this comment.
This will change a lot and it's basically only a placeholder thing for now. I assigned it on a block because originally we also did that for offchainData.
This was referenced Apr 11, 2023
ludamad
pushed a commit
that referenced
this pull request
Jul 19, 2023
ludamad
pushed a commit
that referenced
this pull request
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves:
#10
#11
#12
#13
#14
Checklist: