Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync from noir repo #4047

Merged
merged 4 commits into from
Jan 16, 2024
Merged

chore: sync from noir repo #4047

merged 4 commits into from
Jan 16, 2024

Conversation

TomAFrench
Copy link
Member

subrepo:
subdir: "noir"
merged: "9995d2ba2"
upstream:
origin: "https://github.com/noir-lang/noir"
branch: "aztec-packages"
commit: "9995d2ba2"
git-subrepo:
version: "0.4.6"
origin: "https://github.com/ingydotnet/git-subrepo"
commit: "110b9eb"

subrepo:
  subdir:   "noir"
  merged:   "9995d2ba2"
upstream:
  origin:   "https://github.com/noir-lang/noir"
  branch:   "aztec-packages"
  commit:   "9995d2ba2"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "110b9eb"
@TomAFrench
Copy link
Member Author

This should fix the test failures on the release-please branch

@TomAFrench TomAFrench changed the title git subrepo pull (merge) noir chore: sync from noir repo Jan 16, 2024
@TomAFrench TomAFrench enabled auto-merge (squash) January 16, 2024 16:58
@AztecBot
Copy link
Collaborator

Benchmark results

Metrics with a significant change:

  • node_database_size_in_bytes (10): 5,292,954 (+42%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 4cdc0963 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 220,944 866,324 3,447,644
l1_rollup_execution_gas 934,088 3,968,798 24,791,180
l2_block_processing_time_in_ms 1,509 (+12%) 5,183 (+1%) 21,351
note_successful_decrypting_time_in_ms 309 929 3,388
note_trial_decrypting_time_in_ms 20.7 (+27%) 56.6 (+7%) 139
l2_block_building_time_in_ms 15,988 (+7%) 63,491 (+7%) 255,443 (+8%)
l2_block_rollup_simulation_time_in_ms 11,607 (+10%) 46,166 (+10%) 186,201 (+10%)
l2_block_public_tx_process_time_in_ms 4,349 (-2%) 17,247 (-1%) 68,972

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 15,074 28,833 (+1%)
note_history_successful_decrypting_time_in_ms 2,186 (-1%) 4,287 (-4%)
note_history_trial_decrypting_time_in_ms 134 (+8%) 164 (-8%)
node_database_size_in_bytes 3,621,887 ⚠️ 5,292,954 (+42%)
pxe_database_size_in_bytes 29,923 59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 213 44,681 25,561
private-kernel-ordering 165 43,753 14,809
base-rollup 1,199 (+13%) 128,338 881
root-rollup 79.2 4,088 677
private-kernel-inner 291 71,208 25,561
public-kernel-private-input 206 31,863 25,561
public-kernel-non-first-iteration 203 31,905 25,561
merge-rollup 7.65 2,608 881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 2 leaves 8 leaves 16 leaves 32 leaves 128 leaves 64 leaves 512 leaves 1024 leaves 2048 leaves 8192 leaves
batch_insert_into_append_only_tree_16_depth_ms 11.2 18.9 (+9%) 13.7 17.9 (-4%) 23.6 (-1%) 65.3 (-1%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A N/A N/A N/A 84.4 (-1%) 49.9 243 (-1%) 470 914 3,575
batch_insert_into_indexed_tree_20_depth_ms N/A N/A N/A N/A N/A 112 (-7%) 59.6 360 (-1%) 734 1,415 5,609
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A 64.3 N/A N/A N/A N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 15,455 32,219

Transaction processing duration by data writes.

Metric 0 new commitments 1 new commitments
tx_pxe_processing_time_ms 374 1,086
Metric 1 public data writes
tx_sequencer_processing_time_ms 536

Copy link
Contributor

Changes to circuit sizes

Generated at commit: 76ee788a9c17058365f2110618befdf8984675ac, compared to commit: 470d046fe54c8b4e76d20ca3dbe8e128355b384f

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base -120,480 ✅ -50.49% -97,520 ✅ -6.74%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base 118,164 (-120,480) -50.49% 1,350,272 (-97,520) -6.74%

@TomAFrench TomAFrench merged commit 328c581 into master Jan 16, 2024
4 checks passed
@TomAFrench TomAFrench deleted the tf/sync-noir branch January 16, 2024 19:27
michaelelliot pushed a commit to Swoir/noir_rs that referenced this pull request Feb 28, 2024
subrepo:
  subdir:   "noir"
  merged:   "9995d2ba2"
upstream:
  origin:   "https://github.com/noir-lang/noir"
  branch:   "aztec-packages"
  commit:   "9995d2ba2"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "110b9eb"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants