Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint): looser setting #40

Merged
merged 1 commit into from
Mar 13, 2023
Merged

feat(eslint): looser setting #40

merged 1 commit into from
Mar 13, 2023

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented Mar 13, 2023 •
edited
Loading

Description

The original ESLint config required documenting both fields and their getters and both classes as well as their constructors.

This is still encouraged, however this makes it no longer a requirement.

As well, destructured comments were a bit broken in my experience (the system would complain about something no matter what).

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@ludamad0
feat(eslint): looser setting
84131cf 
The original ESLint config required documenting both fields and their
getters and both classes as well as their constructors.

This is *still encouraged*, however this makes it no longer a
requirement.

As well, destructured comments were a bit broken in my experience.
@ludamad ludamad force-pushed the adam/feat/eslint-relax branch from 20616de to 84131cf Compare March 13, 2023 17:48
@ludamad ludamad requested a review from LHerskind March 13, 2023 17:48
LHerskind
LHerskind approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@LHerskind LHerskind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ludamad ludamad merged commit 21f4f58 into master Mar 13, 2023
@charlielye charlielye deleted the adam/feat/eslint-relax branch March 28, 2023 21:20
ludamad pushed a commit that referenced this pull request Apr 14, 2023
@dbanks12
fix bad mix of designated and non-designated intializers (#40)
84963fd
ludamad pushed a commit that referenced this pull request Apr 17, 2023
@dbanks12 @ludamad
fix bad mix of designated and non-designated intializers (#40)
75d1b5c
ludamad pushed a commit that referenced this pull request Apr 17, 2023
@dbanks12 @ludamad
fix bad mix of designated and non-designated intializers (#40)
e6468a9
ludamad pushed a commit that referenced this pull request Jul 19, 2023
@critesjosh
Merge pull request #40 from AztecProtocol/jc/ga-fix
a202b31 
fix
ludamad pushed a commit that referenced this pull request Jul 21, 2023
@critesjosh
Merge pull request #40 from AztecProtocol/jc/ga-fix
760d388 
fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LHerskind LHerskind LHerskind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ludamad @LHerskind @ludamad0