Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating pedersen benchmarks #3211

Merged
merged 2 commits into from
Nov 20, 2023
Merged

fix: updating pedersen benchmarks #3211

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6601071
resolved segfaults
lucasxia01 Nov 2, 2023
af5003e
keeping it as hash instead of hash_buffer
lucasxia01 Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions barretenberg/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.bench.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ constexpr size_t get_index(const size_t target_count_base)
}
return 0;
}
void generate_test_pedersen_circuit(Builder& builder, size_t num_repetitions)
void generate_test_pedersen_hash_circuit(Builder& builder, size_t num_repetitions)
{
plonk::stdlib::field_t<Builder> left(plonk::stdlib::witness_t(&builder, barretenberg::fr::random_element()));
plonk::stdlib::field_t<Builder> out(plonk::stdlib::witness_t(&builder, barretenberg::fr::random_element()));
Expand All @@ -49,6 +49,17 @@ void generate_test_pedersen_circuit(Builder& builder, size_t num_repetitions)
}
}

void generate_test_pedersen_hash_buffer_circuit(Builder& builder, size_t num_repetitions)
{
stdlib::byte_array<Builder> input;
for (size_t i = 0; i < num_repetitions; ++i) {
stdlib::byte_array<Builder> tmp(plonk::stdlib::witness_t(&builder, barretenberg::fr::random_element()));
input.write(tmp);
}
auto out = proof_system::plonk::stdlib::pedersen_hash<Builder>::hash_buffer(input);
(void)out;
}

plonk::UltraProver pedersen_provers[NUM_CIRCUITS];
plonk::UltraVerifier pedersen_verifiers[NUM_CIRCUITS];
plonk::proof pedersen_proofs[NUM_CIRCUITS];
Expand Down Expand Up @@ -95,12 +106,18 @@ BENCHMARK(native_pedersen_eight_hash_bench)->MinTime(3);

void construct_pedersen_witnesses_bench(State& state) noexcept
{
barretenberg::srs::init_crs_factory(BARRETENBERG_SRS_PATH);

for (auto _ : state) {
state.PauseTiming();
auto builder = Builder(static_cast<size_t>(state.range(0)));
generate_test_pedersen_circuit(builder, static_cast<size_t>(state.range(0)));
generate_test_pedersen_hash_circuit(builder, static_cast<size_t>(state.range(0)));
std::cout << "builder gates = " << builder.get_num_gates() << std::endl;

auto composer = Composer();
composer.compute_proving_key(builder);
state.ResumeTiming();

composer.compute_witness(builder);
}
}
Expand All @@ -120,7 +137,7 @@ void construct_pedersen_proving_keys_bench(State& state) noexcept
{
for (auto _ : state) {
Builder builder = Builder(static_cast<size_t>(state.range(0)));
generate_test_pedersen_circuit(builder, static_cast<size_t>(state.range(0)));
generate_test_pedersen_hash_circuit(builder, static_cast<size_t>(state.range(0)));
size_t idx = get_index(static_cast<size_t>(state.range(0)));

auto composer = Composer();
Expand All @@ -147,7 +164,7 @@ void construct_pedersen_instances_bench(State& state) noexcept
for (auto _ : state) {
state.PauseTiming();
auto builder = Builder(static_cast<size_t>(state.range(0)));
generate_test_pedersen_circuit(builder, static_cast<size_t>(state.range(0)));
generate_test_pedersen_hash_circuit(builder, static_cast<size_t>(state.range(0)));
size_t idx = get_index(static_cast<size_t>(state.range(0)));
auto composer = Composer();
composer.create_prover(builder);
Expand Down