Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update cli payment method option #12423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

LeilaWang
Copy link
Collaborator

  • Only allow to configure feePayer for the --payment option of create-account and deploy-account.
    • If feePayer is set for other commands, it will simply be ignored.
  • Add descriptions for the parameters of the --payment option.

@LeilaWang LeilaWang linked an issue Mar 3, 2025 that may be closed by this pull request
@LeilaWang LeilaWang requested a review from jzaki March 3, 2025 17:09
Copy link
Contributor

@jzaki jzaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For parsing feePayer, should some tests be added that do/don't specify it for different commands?

I'm yet to run this locally to test different commands and the help output, so best to add someone who worked on this for their review too. Maybe @spalladino or @alexghr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli-wallet showing incorrect fee param help in some commands
2 participants