refactor(avm): separate TS dbs and hints and side-effects #12420
+287
−676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76b3ad4 to
de2d36b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STILL WIP
WorldStateDBis removed in favor of using aContractsDBand aTreesDB. This standardized the interface used in the journal, and got rid of the methods to expose the internal merkle db (because now it is "exposed" by default).SideEffectTrace. That class now solely handles tracing of side effects (for the public inputs) and has been massively simplified!ContractsDataSourcePublicDBis wrapped with a class that creates hints for contracts.In the future
TreesDBwith a hint-collecting class.Note that until I implement hints for the trees, there are no merkle-related hints being generated! This is ok because vm2 doesn't use them yet.