Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't use lazy FeeJuice in aztec.js #12352

Merged
merged 4 commits into from
Feb 27, 2025
Merged

fix: don't use lazy FeeJuice in aztec.js #12352

merged 4 commits into from
Feb 27, 2025

Conversation

Thunkar
Copy link
Contributor

@Thunkar Thunkar commented Feb 27, 2025

  • Lazy json imports HAVE to be asserted in node.js.
  • Import assertions are incompatible with browsers
  • Import attributes are compatible with both
  • Import attributes are not supported on firefox
  • aaaaaaaaaaaa

https://caniuse.com/mdn-javascript_statements_import_import_assertions_type_json
https://caniuse.com/mdn-javascript_statements_import_import_attributes_type_json

@Thunkar Thunkar self-assigned this Feb 27, 2025
spalladino
spalladino approved these changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@spalladino spalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate it, but can't think of a better alternative

@Thunkar
Copy link
Contributor Author

Thunkar commented Feb 27, 2025

I hate it, but can't think of a better alternative

Same 😢

@Thunkar Thunkar merged commit 2c1fe48 into master Feb 27, 2025
9 checks passed
@Thunkar Thunkar deleted the gj/fix_bot_lazy_import branch February 27, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalladino spalladino spalladino approved these changes

@Maddiaa0 Maddiaa0 Awaiting requested review from Maddiaa0

Assignees

@Thunkar Thunkar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thunkar @spalladino