feat(spartan): run full nodes along side validators #12335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b56cdb to
b56c1a4
Compare
just-mitch
reviewed
Feb 27, 2025
| @@ -206,15 +206,9 @@ spec: | |||
| - name: COINBASE | |||
| value: "{{ .Values.bootNode.coinbaseAddress }}" | |||
| - name: VALIDATOR_DISABLED | |||
| value: "{{ .Values.bootNode.validator.disabled }}" | |||
| value: "true" | |||
There was a problem hiding this comment.
I'm kind of telling myself that once Phil's pr goes in with the bootnode stuff, we can just change this service to be pure p2p bootstrap, and have a separate job that does l1 deployments.
just-mitch
approved these changes
Feb 27, 2025
Yep big agree, it's my plan next to focus on speeding it up and stripping it down |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calldata gets too big when adding 400 validators to the set at once with the cheatcode,
We dont need all of the validators as there is only 48 per committee, we are better off scaling the number of nodes. This adds configuration to add nodes who are not vals, who will take part in the in networking stack