Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add gates command for client_ivc in new cli #12323

Merged
merged 9 commits into from
Feb 27, 2025
Merged

feat: add gates command for client_ivc in new cli #12323

merged 9 commits into from
Feb 27, 2025

Conversation

saleel
Copy link
Member

@saleel saleel commented Feb 27, 2025

  • Add --scheme flag for gates command in the new bb cli + implement for client_ivc (use existing method)
  • Update usages in flamegraph and profiler (this was already broken as previous gates_for_ivc command was moved under OLD_API flag)

iakovenkos
iakovenkos approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@iakovenkos iakovenkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this!

@saleel saleel enabled auto-merge (squash) February 27, 2025 10:55
@saleel saleel disabled auto-merge February 27, 2025 10:56
@saleel saleel enabled auto-merge (squash) February 27, 2025 12:21
@saleel saleel merged commit 2b94e62 into master Feb 27, 2025
9 checks passed
@saleel saleel deleted the saleel/bb-client-ivc-gates branch February 27, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iakovenkos iakovenkos iakovenkos approved these changes

@ledwards2225 ledwards2225 Awaiting requested review from ledwards2225

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saleel @iakovenkos