fix: Fix for detecting the correct blocks/epochs to prove #12014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalladino
reviewed
Feb 17, 2025
| @@ -216,7 +216,7 @@ export class ProverNode implements EpochMonitorHandler, ProverNodeApi, Traceable | |||
|
|
|||
| // Fast forward world state to right before the target block and get a fork | |||
| this.log.verbose(`Creating proving job for epoch ${epochNumber} for block range ${fromBlock} to ${toBlock}`); | |||
| await this.worldState.syncImmediate(fromBlock - 1); | |||
| await this.worldState.syncImmediate(toBlock); | |||
There was a problem hiding this comment.
This is so we can check that the resulting state of re-executing a block for proving yields the expected world state roots? Otherwise some blocks may still not be on world-state?
Comment on lines
+41
to
+42
| private blockHashes = new Map<number, string>(); | ||
| private l2Tips: L2Tips | undefined = undefined; |
There was a problem hiding this comment.
The L2TipsStore encapsulates most of the work for keeping the "local" view of the data in sync. Maybe using it here would remove some code from this class.
| this.log.trace(`Received chain proven event for block ${event.blockNumber}`); | ||
|
|
||
| // Update our proven tip and clean any historic blocks | ||
| this.l2Tips!.proven.hash = undefined; |
There was a problem hiding this comment.
We should be able to grab the hash from the blockHashes map, right?
spalladino
reviewed
Feb 17, 2025
There was a problem hiding this comment.
Why not add the test here to e2e_epochs to reuse most of the setup and helpers?
spalladino
added a commit
that referenced
this pull request
Feb 21, 2025
Fixes the prover-node's epoch monitor so it accounts for the previous epoch to be proven. The updated logic is that an epoch is ready to prove only if it is completed and it contains the first unproven block (which gets updated over a reorg). Also fixes #11840 Builds on top of @PhilWindle's #12014 --------- Co-authored-by: PhilWindle <philip.windle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read contributing guidelines and remove this line.