Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make compute_initialization_hash public again #11399

Closed

Conversation

twt--
Copy link
Contributor

@twt-- twt-- commented Jan 21, 2025

compute_initialization_hash was recently switched to private in #11129 efab709#diff-4ecf647dda8cae1b37fca32431de3d66507ea172383284deee8c4524cca9538bL63

This PR makes it public again. I'm using it in my contracts to verify that contract instances were deployed with the expected arguments. If there is a better way to check that, please let me know and I'll switch to that instead.

@TomAFrench TomAFrench requested a review from benesjan January 22, 2025 08:39
Copy link
Contributor

@benesjan benesjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for mindlessly hiding this from the public API.

Thanks for the fix

@benesjan benesjan enabled auto-merge (squash) January 22, 2025 15:12
@benesjan
Copy link
Contributor

@twt-- our CI is currently broken for external contributors so I am closing this and opening a duplicate under my name.

@benesjan benesjan closed this Jan 22, 2025
auto-merge was automatically disabled January 22, 2025 15:43

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants