Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sync from noir #11279

Merged
merged 5 commits into from
Jan 17, 2025
Merged

feat: Sync from noir #11279

merged 5 commits into from
Jan 17, 2025

Conversation

AztecBot
Copy link
Collaborator

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore: add regression test for #6530 (noir-lang/noir#7089)
feat: add ConstrainNotEqual instruction (noir-lang/noir#7032)
feat!: loop statements (only frontend) (noir-lang/noir#7092)
fix!: Include kind in StructDefinition::generics and fix derivation of Eq in structs with numeric generics (noir-lang/noir#7076)
chore: add test for isuee #7090 (noir-lang/noir#7091)
chore: mark noir-edwards as expected to compile (noir-lang/noir#7085)
chore: allow passing custom conditions to inlining pass (noir-lang/noir#7083)
feat(LSP): auto-import trait reexport if trait is not visible (noir-lang/noir#7079)
fix: Allow implicit associated types on integer type kinds (noir-lang/noir#7078)
feat(ssa): Treat globals as constant in a function's DFG (noir-lang/noir#7040)
chore: Do not make new instruction if it hasn't changed (noir-lang/noir#7069)
fix: do not remove memory blocks used as brillig input (noir-lang/noir#7073)
END_COMMIT_OVERRIDE

AztecBot and others added 3 commits January 16, 2025 19:53
feat: add `ConstrainNotEqual` instruction (noir-lang/noir#7032)
feat!: `loop` statements (only frontend) (noir-lang/noir#7092)
fix!: Include kind in `StructDefinition::generics` and fix derivation of Eq in structs with numeric generics (noir-lang/noir#7076)
chore: add test for isuee #7090 (noir-lang/noir#7091)
chore: mark `noir-edwards` as expected to compile (noir-lang/noir#7085)
chore: allow passing custom conditions to inlining pass (noir-lang/noir#7083)
feat(LSP): auto-import trait reexport if trait is not visible (noir-lang/noir#7079)
fix: Allow implicit associated types on integer type kinds (noir-lang/noir#7078)
feat(ssa): Treat globals as constant in a function's DFG (noir-lang/noir#7040)
chore: Do not make new instruction if it hasn't changed (noir-lang/noir#7069)
fix: do not remove memory blocks used as brillig input (noir-lang/noir#7073)
* master: (395 commits)
  chore: Log correlation in traces in google cloud (#11276)
  fix: Reallocate commitment key to avoid pippenger error (#11249)
  feat: archive public testnet tx data (#11192)
  chore: remove warnings from types and rollup lib crates (#11269)
  fix: Faster polling times for archiver and sequencer (#11262)
  chore: Remove references to padding txs (#11264)
  chore(avm): calldata, returndata slices out of range padded with zeros (#11265)
  feat: process note logs in aztec-nr (#10651)
  feat: track block building helpers (#11190)
  chore: silence circuit return values in CI (#11259)
  chore: Demote error closing forks to warn (#11263)
  chore:  move shared pcs functionality to internal library in solidity and small refactorings in sumcheck (#11230)
  chore: delete external-ci-approved.yml (#11258)
  feat: reenable constrained config for roots (#10605)
  feat(docs): algolia->typesense (#11034)
  fix: references to a3 in docs (#11256)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  ...
@TomAFrench TomAFrench enabled auto-merge (squash) January 16, 2025 21:25
Copy link
Contributor

Changes to public function bytecode sizes

Generated at commit: 715f34102f2b7a3ed023fde4da5dad8087f3180c, compared to commit: 0b2a61901d183ffe6389a6543a379acfef25c5e5

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
AvmTest::public_dispatch -420 ✅ -0.67%
AvmTest::bulk_testing -420 ✅ -1.82%
AvmTest::sha256_hash -420 ✅ -11.11%

Full diff report 👇
Program Bytecode size in bytes (+/-) %
AvmTest::public_dispatch 62,128 (-420) -0.67%
AvmTest::bulk_testing 22,676 (-420) -1.82%
AvmTest::sha256_hash 3,360 (-420) -11.11%

@TomAFrench TomAFrench merged commit a964cd0 into master Jan 17, 2025
51 checks passed
@TomAFrench TomAFrench deleted the sync-noir branch January 17, 2025 00:47
Copy link
Contributor

Changes to circuit sizes

Generated at commit: 715f34102f2b7a3ed023fde4da5dad8087f3180c, compared to commit: 0b2a61901d183ffe6389a6543a379acfef25c5e5

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_inner -2 ✅ -0.01% -2 ✅ -0.00%
private_kernel_init -2 ✅ -0.01% -2 ✅ -0.01%
private_kernel_tail_to_public -2 ✅ -0.02% -2 ✅ -0.01%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_inner 28,368 (-2) -0.01% 72,234 (-2) -0.00%
private_kernel_init 18,679 (-2) -0.01% 39,846 (-2) -0.01%
private_kernel_tail_to_public 12,445 (-2) -0.02% 37,942 (-2) -0.01%

@TomAFrench
Copy link
Member

@sirasistant, fyi the Eq changes are in here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants