Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: kill prover node and see it recover #11118

Merged
merged 10 commits into from
Feb 20, 2025
Merged

test: kill prover node and see it recover #11118

merged 10 commits into from
Feb 20, 2025

Conversation

alexghr
Copy link
Contributor

@alexghr alexghr commented Jan 9, 2025

Fix #11117

Test that forcefully shuts down the prover node and sees it recover and pick back up the epoch proving job it was working on.

@alexghr alexghr force-pushed the ag/test-prover-node-recovery-rebased branch from 0e05cb7 to a5a3149 Compare February 11, 2025 11:48
PhilWindle
PhilWindle approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@PhilWindle PhilWindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

yarn-project/end-to-end/src/spartan/prover-node.test.ts Outdated
* unique inputs for each txs so jobs will only get cached after crash recovery.
* We could also use the tube proof for this, but in a simulated network, all tube proof jobs take the same input proof: the empty private kernel proof.
*/
const PROOF_TYPE = '"PUBLIC_BASE_ROLLLUP"'; // note: double quotes!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PUBLIC_BASE_ROLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLUP

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited
Loading

Changes to public function bytecode sizes

Generated at commit: 5fcbd28bc9019096f40cc07454ce2a559613516e, compared to commit: 95b581de29df183c7ee443c990fef11a3f9a301e

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
TokenBlacklist::public_dispatch +42 ❌ +0.18%
Full diff report 👇
Program Bytecode size in bytes (+/-) %
TokenBlacklist::public_dispatch 23,831 (+42) +0.18%

@github-actions GitHub Actions
Copy link
Contributor

Changes to circuit sizes

Generated at commit: 5fcbd28bc9019096f40cc07454ce2a559613516e, compared to commit: 95b581de29df183c7ee443c990fef11a3f9a301e

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base_public +120,592 ❌ +140.07% +370,468 ❌ +31.68%
rollup_block_merge +24,164 ❌ +362.50% +84,229 ❌ +5.27%
rollup_root +24,164 ❌ +363.37% +84,229 ❌ +0.31%
rollup_base_private +6 ❌ +0.00% +590 ❌ +0.04%
private_kernel_inner -179 ✅ -0.63% -446 ✅ -0.61%
private_kernel_init -179 ✅ -0.95% -446 ✅ -1.11%
Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base_public 206,684 (+120,592) +140.07% 1,540,029 (+370,468) +31.68%
rollup_block_merge 30,830 (+24,164) +362.50% 1,683,390 (+84,229) +5.27%
rollup_root 30,814 (+24,164) +363.37% 26,939,539 (+84,229) +0.31%
rollup_base_private 137,836 (+6) +0.00% 1,637,949 (+590) +0.04%
private_kernel_inner 28,367 (-179) -0.63% 72,233 (-446) -0.61%
private_kernel_init 18,679 (-179) -0.95% 39,846 (-446) -1.11%

@alexghr alexghr force-pushed the ag/test-prover-node-recovery-rebased branch 2 times, most recently from fb67624 to 2e88cb2 Compare February 19, 2025 13:22
@alexghr alexghr force-pushed the ag/test-prover-node-recovery-rebased branch from 2e88cb2 to b67000e Compare February 20, 2025 09:29
@alexghr alexghr requested a review from charlielye as a code owner February 20, 2025 13:22
@alexghr alexghr enabled auto-merge (squash) February 20, 2025 13:40
@alexghr alexghr merged commit 36ebe30 into master Feb 20, 2025
12 checks passed
@alexghr alexghr deleted the ag/test-prover-node-recovery-rebased branch February 20, 2025 13:58
TomAFrench added a commit that referenced this pull request Feb 20, 2025
@TomAFrench
Merge branch 'master' into sync-noir
ad66e8d 
* master: (300 commits)
  fix(ci): don't have checks go green immediately (#12168)
  fix: ASSERTS that should throw (#12167)
  fix: retry rm operation in cleanup (#12162)
  chore: Fix linter errors (#12164)
  feat: Barretenberg C++ binary overhaul (#11459)
  fix: call install_hooks in bootstrap (#12159)
  chore: @aztec/stdlib pt. 3: aztec-address out of foundation (#12140)
  test: verify proving is resumed after broker crash (#11122)
  chore(ci3): update ci.md with swc notes (#12147)
  fix: don't try to get bench artifacts on external PR (#12157)
  feat: partial note handling in aztec-nr (#12122)
  fix: external fixes pt 2 (#12153)
  chore: fix message path (#12150)
  chore(ci3): refactor ci3.yml, fix external PR flow (#12037)
  fix: Do not try flushing txs in bot setup if not set (#12144)
  chore: Silence warns on invalid bootnode enr (#12135)
  fix: don't early-out on test fails (#12143)
  feat(avm): deduplicating event emitters (#12137)
  chore: @aztec/stdlib pt.2 -> remove @aztec/types (#12133)
  test: kill prover node and see it recover (#11118)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilWindle PhilWindle PhilWindle approved these changes

@charlielye charlielye Awaiting requested review from charlielye charlielye is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Prover][Test] System must recover if prover node goes down temporarily
2 participants
@alexghr @PhilWindle