Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: multiplier "oracles" for fees #9718

Closed
just-mitch opened this issue Nov 4, 2024 · 0 comments · Fixed by #9902
Closed

feat: multiplier "oracles" for fees #9718

just-mitch opened this issue Nov 4, 2024 · 0 comments · Fixed by #9902
Assignees
@LHerskind
Labels
C-l1-contracts Component: contracts deployed to L1 C-node Component: Aztec Node
Milestone
TestNet

Comments

@just-mitch
Copy link
Collaborator

just-mitch commented Nov 4, 2024 •
edited by LHerskind
Loading

As specified by the design document, we should implement a few "multiplier" oracles:

  • One for the proving cost per unit of compute
  • One for the fee paying asset to ether

Both of these should be build with the mechanism of that doc.
@just-mitch just-mitch added C-l1-contracts Component: contracts deployed to L1 C-node Component: Aztec Node labels Nov 4, 2024
@just-mitch just-mitch added this to the TestNet milestone Nov 4, 2024
@just-mitch just-mitch assigned just-mitch and unassigned just-mitch Nov 4, 2024
@LHerskind LHerskind changed the title add proving cost oracle to l1 contracts feat: multipler "oracles" Nov 7, 2024
@LHerskind LHerskind changed the title feat: multipler "oracles" feat: multiplier "oracles" Nov 7, 2024
@LHerskind LHerskind changed the title feat: multiplier "oracles" feat: multiplier "oracles" for fees Nov 7, 2024
@LHerskind LHerskind mentioned this issue Nov 7, 2024
Closed
@LHerskind LHerskind self-assigned this Nov 7, 2024
This was referenced Nov 12, 2024
Merged
Merged
LHerskind added a commit that referenced this issue Nov 13, 2024
@LHerskind
feat: multiplier oracle (#9902)
6456ec9 
Fixes #9718. Implements the oracles relying directly on the
`fake_exponential` e,g., the proving cost and fee asset cost.

Using the data generated from
AztecProtocol/engineering-designs#38 and checks
that the solidity implementation matches the values from the python.

The `MinimalFeeModel` showcase the storage needed and computations, the
same logic logic will end up living closer to the rollup contract in
what #9804
stevenplatt pushed a commit that referenced this issue Nov 13, 2024
@LHerskind @stevenplatt
feat: multiplier oracle (#9902)
f1aca1b 
Fixes #9718. Implements the oracles relying directly on the
`fake_exponential` e,g., the proving cost and fee asset cost.

Using the data generated from
AztecProtocol/engineering-designs#38 and checks
that the solidity implementation matches the values from the python.

The `MinimalFeeModel` showcase the storage needed and computations, the
same logic logic will end up living closer to the rollup contract in
what #9804
This was referenced Nov 14, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LHerskind LHerskind

Labels
C-l1-contracts Component: contracts deployed to L1 C-node Component: Aztec Node
Projects
None yet
Milestone
TestNet
Development

Successfully merging a pull request may close this issue.

feat: multiplier oracle AztecProtocol/aztec-packages
2 participants
@LHerskind @just-mitch