Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make simulations validate the resulting TX by default #7956

Closed
nventuro opened this issue Aug 13, 2024 · 0 comments · Fixed by #8157
Closed

Make simulations validate the resulting TX by default #7956

nventuro opened this issue Aug 13, 2024 · 0 comments · Fixed by #8157
Assignees
@sklppy88

Comments

@nventuro
Copy link
Contributor

#7839 introduced the skipTxValidation option, but left it set to true by default, preserving the current behavior. We should change this to false and adjust any callsites, e2e test etc that may require simulations that result in invalid transactions.
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 13, 2024
@sklppy88 sklppy88 mentioned this issue Aug 26, 2024
Merged
@sklppy88 sklppy88 moved this from Todo to In Review in A3 Aug 27, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Aug 30, 2024
codygunton pushed a commit that referenced this issue Aug 30, 2024
@sklppy88 @codygunton
fix: make simulations validate resulting tx by default (#8157)
2203bc0 
Closes #7956.

This PR simply flips a switch to make all simulations fail by default if
the transaction is an invalid one. Previously it did not throw due to
wanting to minimize disruptions in the PR, but it seems like there were
not that many effects. The only exception is the e2e prover. These are
failing due to a prover verification, and I have made an issue for this
to be looked into.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sklppy88 sklppy88

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make simulations validate resulting tx by default AztecProtocol/aztec-packages
2 participants
@nventuro @sklppy88