Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SECURITY] Make bytecode part of artifact hash preimage again #5860

Closed
benesjan opened this issue Apr 19, 2024 · 0 comments · Fixed by #9771
Closed

[SECURITY] Make bytecode part of artifact hash preimage again #5860

benesjan opened this issue Apr 19, 2024 · 0 comments · Fixed by #9771
Labels
A-security Area: Relates to security. Something is insecure. team-fairies Nico's team

Comments

@benesjan
Copy link
Contributor

benesjan commented Apr 19, 2024 •
edited
Loading

This was disabled due to issues with noir's non-determinism and it blocking CI from passing (see this discussion).

To spot the place what change to revert look for "TODO(#5860)" in the codebase.

The PR disabling the check was merged in this commit.
@github-project-automation github-project-automation bot moved this to Todo in A3 Apr 19, 2024
@benesjan benesjan added the A-security Area: Relates to security. Something is insecure. label Apr 19, 2024
This was referenced Oct 28, 2024
Closed
Open
@sklppy88 sklppy88 mentioned this issue Nov 6, 2024
Merged
@nventuro nventuro added the team-fairies Nico's team label Nov 7, 2024
@sklppy88 sklppy88 linked a pull request Nov 11, 2024 that will close this issue
fix: sorting artifact props and members in metadata #9772
Merged
@sklppy88 sklppy88 removed a link to a pull request Nov 11, 2024
fix: sorting artifact props and members in metadata #9772
Merged
@sklppy88 sklppy88 linked a pull request Nov 11, 2024 that will close this issue
fix: make bytecode part of artifact hash preimage again #9771
Merged
sklppy88 added a commit that referenced this issue Nov 21, 2024
@sklppy88
fix: make bytecode part of artifact hash preimage again (#9771)
cdabd85 
In this PR, we are simply trying to re-introduce the bytecode hash as a
part of the preimage to the function artifact hash.

I had tried to reproduce the weird noir non-deterministic bytecode bug
that @spalladino documented
[here](https://aztecprotocol.slack.com/archives/C053490AV6V/p1713480846092319?thread_ts=1713445232.979779&cid=C053490AV6V)
referenced in #5860 but was unable to do so.

I see only matched bytecode hashes on local and CI:
<img width="807" alt="•noir-projects+build-contracts bar_far,"
src="https://github.com/user-attachments/assets/404ae02f-4f72-4ea4-a5e1-43b2d96d507b">

<img width="733" alt="Pasted Graphic 6"
src="https://github.com/user-attachments/assets/1a7e15bf-6ca6-45ab-bfa7-4b97ea336e61">
 

If this has been already fixed by the noir team it may make sense that
this should be merged in to simply re-add the security check.
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-security Area: Relates to security. Something is insecure. team-fairies Nico's team
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make bytecode part of artifact hash preimage again AztecProtocol/aztec-packages
2 participants
@nventuro @benesjan