Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engineer can stop the P2P module #5

Closed
PhilWindle opened this issue Mar 2, 2023 · 1 comment
Closed

Engineer can stop the P2P module #5

PhilWindle opened this issue Mar 2, 2023 · 1 comment
Assignees
@spypsy

Comments

@PhilWindle
Copy link
Collaborator

The P2P module should be able to be stopped. Once stopped it should indicate that it is stopped via it's status interface and should no longer sync to new rollups.
@PhilWindle PhilWindle added this to A3 Mar 2, 2023
@PhilWindle PhilWindle converted this from a draft issue Mar 2, 2023
@PhilWindle PhilWindle added this to the 📜 Deploy a Contract milestone Mar 7, 2023
@spypsy spypsy moved this from Todo to In Progress in A3 Mar 10, 2023
@spypsy spypsy self-assigned this Mar 10, 2023
@spypsy spypsy moved this from In Progress to In Review in A3 Mar 10, 2023
@PhilWindle PhilWindle moved this from In Review to Done in A3 Apr 3, 2023
@iAmMichaelConnor
Copy link
Contributor

Closing as "Done" in A3 project board.

ludamad pushed a commit that referenced this issue Jul 14, 2023
@charlielye @dbanks12 @Rumata888
Aztec3 (#5)
991985c 
* Fix to bootstrap.sh after move into submodule (#1)

* Updated bootstrap now that bberg may be a submodule, and now that cpp subdir exists

* fix gitignore, wasnt properly ignoring cpp/build*

* fix the barretenberg cpp formatting pre-commit hook now that barretenberg iss its own repo and may be a submodule

* Contrived change.

* Revert "Contrived change."

This reverts commit ea18e58180f70a5e0f0a3419f4beba461d6917cb.

* Revert "Revert "Contrived change.""

This reverts commit 6ad33bccc4e5a1d76467a61b0d18d369fd32988e.

* Introduce cpp to paths.

* More cpp path.

* Cl/mum merge (#4)

* Initial merge. Still has conflicts.

* Tidied up bigfield and biggroup

* Builds.

* Order constants.

* Fix.

* Make more tests pass.

* Update circuit change detection stuff to be local to tests.

* Include header.

* Cleanup and settings.

* Path updates.

* Path updates.

Co-authored-by: Rumata888 <isennovskiy@gmail.com>

Co-authored-by: David Banks <47112877+dbanks12@users.noreply.github.com>
Co-authored-by: Rumata888 <isennovskiy@gmail.com>
ludamad pushed a commit that referenced this issue Jul 19, 2023
@critesjosh
Merge pull request #5 from brunny-eth/patch-1
18db520 
Update technical-intro.md
ludamad pushed a commit that referenced this issue Jul 21, 2023
@critesjosh
Merge pull request #5 from brunny-eth/patch-1
afb4e1b 
Update technical-intro.md
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Jul 26, 2023
codygunton pushed a commit that referenced this issue Jan 23, 2024
@charlielye @dbanks12 @Rumata888
Aztec3 (#5)
63391aa 
* Fix to bootstrap.sh after move into submodule (#1)

* Updated bootstrap now that bberg may be a submodule, and now that cpp subdir exists

* fix gitignore, wasnt properly ignoring cpp/build*

* fix the barretenberg cpp formatting pre-commit hook now that barretenberg iss its own repo and may be a submodule

* Contrived change.

* Revert "Contrived change."

This reverts commit 68aff9c99c683956f417d069360ca36deb5e351c.

* Revert "Revert "Contrived change.""

This reverts commit 3eee2fdd5133490ae57fd2db94c645891e3e8fcf.

* Introduce cpp to paths.

* More cpp path.

* Cl/mum merge (#4)

* Initial merge. Still has conflicts.

* Tidied up bigfield and biggroup

* Builds.

* Order constants.

* Fix.

* Make more tests pass.

* Update circuit change detection stuff to be local to tests.

* Include header.

* Cleanup and settings.

* Path updates.

* Path updates.

Co-authored-by: Rumata888 <isennovskiy@gmail.com>

Co-authored-by: David Banks <47112877+dbanks12@users.noreply.github.com>
Co-authored-by: Rumata888 <isennovskiy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spypsy spypsy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@spypsy @iAmMichaelConnor @PhilWindle